Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar to both #417 and #418. Fixes errors when PCL_NO_PRECOMPILE=ON #534

Merged
merged 1 commit into from
Mar 2, 2014

Conversation

chambbj
Copy link
Contributor

@chambbj chambbj commented Feb 27, 2014

referenced in #521

@taketwo
Copy link
Member

taketwo commented Feb 27, 2014

Shouldn't explicit template instantiation in 'octree_inst.cpp' be ifndef'ed then?

@taketwo
Copy link
Member

taketwo commented Mar 1, 2014

@chambbj Sorry for the delay. Actually github does not send notifications when a new commit is added to a pull request, so we have no means to learn about your activity unless you also comment after pushing new stuff.

Regarding the PR itself. The "test" run on Travis failed. (Not because of your modification, but for some other reasons. It happens some times). But it would be nice to see it succeeding. Could you please squash the two commits and push again? This way we'll kill two birds with one stone: commit history will be prettier and Travis will re-run tests. Thanks!

@chambbj
Copy link
Contributor Author

chambbj commented Mar 2, 2014

@taketwo No problem. Pushed!

@chambbj
Copy link
Contributor Author

chambbj commented Mar 2, 2014

Ugh, it would help if I remembered to build with PCL_NO_PRECOMPILE=ON. I'll get back to you @takewo.

@chambbj
Copy link
Contributor Author

chambbj commented Mar 2, 2014

@taketwo We should be good now.

@taketwo
Copy link
Member

taketwo commented Mar 2, 2014

So you fixed those undefined references to OctreeBase::xxx in the previous build by tweaking 'voxel_grid_occlusion_estimation', 'line_rgbd', and 'poisson'? Seems totally unrelated at the first glance, how did you figure this out?

@chambbj
Copy link
Contributor Author

chambbj commented Mar 2, 2014

@taketwo No, the undefined references originally occurred because I had the #ifdef PCL_NO_PRECOMPILE located before the class exports. The tweaks to voxel_grid_occlusion estimation, line_rgbd, and poisson were in response to compiler errors that appeared after the first change.

@taketwo
Copy link
Member

taketwo commented Mar 2, 2014

Ah, I see.

taketwo added a commit that referenced this pull request Mar 2, 2014
Similar to both #417 and #418. Fixes errors when PCL_NO_PRECOMPILE=ON
@taketwo taketwo merged commit be4e086 into PointCloudLibrary:master Mar 2, 2014
@chambbj chambbj deleted the fix-octree-search branch March 3, 2014 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants