Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Move app kinect_viewer_cuda to general app directory #5529

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SunBlack
Copy link
Contributor

Following-up of #5528

Currently only draft, as there some issues:

  • topological_sort sorts apps before cuda => didn't debugged why, but called add_subdirectory separately to solve this issue
  • See,s the CUDA target have wrong include directories defined as it is including now pcl/cuda/include instead of ``pcl/cuda/io/include` (therefore Draft as I didn't found a fast workaround for it)

@SunBlack SunBlack changed the title Draft: Move kinect viewer cuda Draft: Move app kinect_viewer_cuda to general app directory Nov 25, 2022
@larshg
Copy link
Contributor

larshg commented Jan 7, 2023

collect_subproject_directory_names only search first level of directories, ie. it finds cuda and gpu... But not subdirectories. So its flawed.
I tried to use a GPU method in benchmarks and I just experienced the same.
Didn't find a good solution either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants