replace boost filesystem exists #5907
Conversation
|
Hi, my idea was not to replace every |
|
I believe it would make sense to first check whether the |
| return (-1); | ||
| } | ||
|
|
||
| if (mtl_file_name.empty()) |
There was a problem hiding this comment.
Moved to pcl::MTLReader::read (const std::string& mtl_file_path).
There was a problem hiding this comment.
But removing this check here would change the behaviour: if mtl_file_name is empty here, then mtl_file_path below would contain obj_file_path.parent_path() (and maybe a slash or backslash at the end), meaning mtl_file_path would not be empty. So as I see it, it is necessary to keep this check here.
io/src/ifs_io.cpp
Outdated
| // Open file in binary mode to avoid problem of | ||
| // std::getline() corrupting the result of ifstream::tellg() |
There was a problem hiding this comment.
This comment does not make sense to me: std::getline is not used in ifs_io.cpp?
| return (-1); | ||
| } | ||
|
|
||
| if (mtl_file_name.empty()) |
There was a problem hiding this comment.
But removing this check here would change the behaviour: if mtl_file_name is empty here, then mtl_file_path below would contain obj_file_path.parent_path() (and maybe a slash or backslash at the end), meaning mtl_file_path would not be empty. So as I see it, it is necessary to keep this check here.
Partially revert PointCloudLibrary#5974 and PointCloudLibrary#5988 and PointCloudLibrary#5907 After the 1.14.1 release, we can re-apply these changes. The ABI checker reported: `The parameter file_name became passed in r12 register instead of r13. Applications will read the wrong memory block instead of the parameter value.` and `The parameter cloud_tgt_demean became passed in r12 register instead of r13.` These changes are not super important, so I think it doesn't hurt to temporarily revert them to achieve 100% ABI compatibility between 1.14.0 and 1.14.1.
Task 3 of #5881