Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: tool to generate random clouds #599

Merged
merged 1 commit into from
Apr 1, 2014

Conversation

chambbj
Copy link
Contributor

@chambbj chambbj commented Mar 31, 2014

No description provided.

{
print_error ("Syntax is: %s output.pcd <options>\n", argv[0]);
print_info (" where options are:\n");
print_info (" -method X = the morphological operator to be used (options: uniform / normal) (default: ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morphological? :)

@taketwo
Copy link
Member

taketwo commented Apr 1, 2014

Wouldn't it make sense to group the options in the help to avoid repetition? Something like:

  * method
  * width
  * height
Options for uniform distribution:
  * xmin - ...
  * ...
Options for normal distribution:
  * ...

@chambbj
Copy link
Contributor Author

chambbj commented Apr 1, 2014

@taketwo This look better?

@taketwo
Copy link
Member

taketwo commented Apr 1, 2014

Yes, thank you.

Hmm.. speaking about width and height. In PCL, if height is >1, the point cloud is considered organized. This implies, for example, that two points that go one after another in the point cloud storage vector are also neighbors in the spatial domain. Some algorithms take advantage of this fact. But when a point cloud is generated randomly it is obviously not organized. So I think rather than having "width" and "height" parameters it is better to just have "size" and generate a point cloud with dimensions size x 1, so it is considered unorganized.

(I have no clue why the fill function takes width and height, for the mentioned reasons I think this does not make any sense.)

@chambbj
Copy link
Contributor Author

chambbj commented Apr 1, 2014

@taketwo Good point. Fixed in the latest commit.

@taketwo
Copy link
Member

taketwo commented Apr 1, 2014

Great, merging this!

taketwo added a commit that referenced this pull request Apr 1, 2014
Add: tool to generate random clouds
@taketwo taketwo merged commit a646722 into PointCloudLibrary:master Apr 1, 2014
@chambbj chambbj deleted the add-generate-tool branch April 1, 2014 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants