Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a curvature parameter to region_3d. This parameter characterizes the mean curvature of the 3D region. #653

Merged
merged 1 commit into from
May 21, 2014

Conversation

EduFdez
Copy link

@EduFdez EduFdez commented Apr 21, 2014

No description provided.

@jspricke
Copy link
Member

Hi @EduFdez, thanks for your contribution. Could you please remove the unneeded whitespace changes? Otherwise I'm fine with your commit.

@EduFdez
Copy link
Author

EduFdez commented May 19, 2014

Hi @jspricke, I've removed such unneeded whitespace changes. Thank you.

@jspricke
Copy link
Member

Thanks Eduardo, can you squash your commits int one? Have a look at git rebase -i to do it.

Added a curvature parameter to region_3d

Rebase test

Update region_3d.h

Update region_3d.h

Update region_3d.h
@EduFdez
Copy link
Author

EduFdez commented May 19, 2014

Hi Jochen, is it ok now?

@jspricke
Copy link
Member

Hi Eduardo, you need to to a git push -f, to update your branch on Github. Otherwise you still have all old commits.

@EduFdez
Copy link
Author

EduFdez commented May 21, 2014

I believe it's OK now. Pleae, can you check it again Jochen?

@taketwo
Copy link
Member

taketwo commented May 21, 2014

Looks good. Thanks Eduardo!

taketwo added a commit that referenced this pull request May 21, 2014
Added a curvature parameter to region_3d. This parameter characterizes the mean curvature of the 3D region.
@taketwo taketwo merged commit c132238 into PointCloudLibrary:master May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants