Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: approximate version of the progressive morphological filter #665

Merged
merged 1 commit into from
May 22, 2014

Conversation

chambbj
Copy link
Contributor

@chambbj chambbj commented May 7, 2014

This version is closer to the original paper and significantly faster,
computing the morphological operations on a 2D grid.

@chambbj chambbj assigned aichim and gedikli and unassigned aichim May 11, 2014
@@ -64,7 +65,7 @@ if(build)
"include/pcl/${SUBSYS_NAME}/conditional_euclidean_clustering.h"
"include/pcl/${SUBSYS_NAME}/supervoxel_clustering.h"
"include/pcl/${SUBSYS_NAME}/grabcut_segmentation.h"
"include/pcl/${SUBSYS_NAME}/progressive_morphological_filter.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep this file as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks for catching it. I'll push an update today.

This version is closer to the original paper and significantly faster,
computing the morphological operations on a 2D grid.
@chambbj
Copy link
Contributor Author

chambbj commented May 22, 2014

@jspricke I've addressed your comment on this one. Travis only failed due to gcc timing out at 50 minutes, so we should be good to go!

jspricke added a commit that referenced this pull request May 22, 2014
Add: approximate version of the progressive morphological filter
@jspricke jspricke merged commit 592af49 into PointCloudLibrary:master May 22, 2014
@chambbj chambbj deleted the approx-pmf branch June 27, 2014 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants