Unifies sac_model_normal_parallel_plane with sac_model_normal_plane, removes duplicated code #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no error, the gcc build timedout |
|
Looks good to me. |
| @@ -107,8 +105,7 @@ namespace pcl | |||
| */ | |||
| SampleConsensusModelNormalParallelPlane (const PointCloudConstPtr &cloud, | |||
| bool random = false) | |||
| : SampleConsensusModelPlane<PointT> (cloud, random) | |||
| , SampleConsensusModelFromNormals<PointT, PointNT> () | |||
| : SampleConsensusModelNormalPlane<PointT, PointNT>(cloud, random) | |||
There was a problem hiding this comment.
Could you please add a space in front of the bracket?
…removes duplicated code
taketwo
added a commit
that referenced
this pull request
May 24, 2014
Unifies sac_model_normal_parallel_plane with sac_model_normal_plane, removes duplicated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes are very similar, sac_model_normal_parallel_plane changes isModelValid method to filter out planes that don't comply with the axis restrictions.