Four-point congruent sets algorithm (FPCS) #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4-point congruent sets algorithm for alignment 3D models
Header file for 4PCS algorithm for alignment 3D models
Implementation of algorithm 4PCS
|
Hi, The PCL Style Guide specify you have to use space indentations only (no tabs). Just replace all your tabulations with two white spaces! You didn't write doxygen documentation, which makes your code difficult to use, could you write it ? You can find examples in other PCL files for the syntax Bye! |
|
Hi, Understood. I'll correct it |
|
|
||
| ~FPCS () | ||
| { | ||
| source_markers_->~PointCloud(); |
There was a problem hiding this comment.
No need to call destructors explicitly, shared_ptr will do that for you automatically.
|
Hi Sergey, thanks for the contribution. Please consider a few inline comments that I left. Also, we will need to construct (at least a simple) unit test for the new class. |
|
Considering we merged #976, can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4PCS algorithm for alignment 3D models.