Fix Disappearing cloud from Selection #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpapon Could you please have a look? |
frankpablo
changed the title
|
The issue was discussed here. |
|
This looks good to me - simple fix to the problem. |
| @@ -72,8 +76,12 @@ pcl::cloud_composer::MergeSelection::performAction (ConstItemList input_data, Po | |||
| filter.filter (*selected_points); | |||
|
|
|||
| qDebug () << "Original minus indices is "<<original_minus_indices->width; | |||
| Eigen::Vector4f source_origin = input_cloud_item->data (ItemDataRole::ORIGIN).value<Eigen::Vector4f> (); | |||
| Eigen::Quaternionf source_orientation = input_cloud_item->data (ItemDataRole::ORIENTATION).value<Eigen::Quaternionf> (); | |||
| if(!pose_found) | |||
|
@frankpablo Could you please fix a couple of minor things so that we can merge your patch? |
|
OK, that should do it. |
|
I am afraid space is still missing in |
|
Sorry, quite new to this, I'm following the squash instructions but the "git rebase -i master" command is not displaying the list of commits to squash. What am I doing wrong? |
|
Did you checkout your feature branch? |
The new cloud from selection is created with the pose information of the original cloud. If more than one original clouds are selected, the pose of the first one is used. minor style corrections style correction
|
Great! |
taketwo
added a commit
that referenced
this pull request
Aug 12, 2014
Fix Disappearing cloud from Selection
|
I thought I had. I repeated it and it worked this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new cloud from selection is created with the pose information of
the original cloud. If more than one original clouds are selected,
the pose of the first one is used.