Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions to query depth, ir and color frame count. #843

Merged
merged 1 commit into from
Aug 12, 2014
Merged

Added functions to query depth, ir and color frame count. #843

merged 1 commit into from
Aug 12, 2014

Conversation

nylocx
Copy link

@nylocx nylocx commented Aug 9, 2014

This new functions can be used to determin the end of an .oni file stream.

@jspricke
Copy link
Member

jspricke commented Aug 9, 2014

+1

@taketwo
Copy link
Member

taketwo commented Aug 11, 2014

Could you please do the following:

  • Format according to the PCL style guide
    • use double space for indents
    • add spaces between function names and braces
    • put { on separate lines
  • Add a short doxygen comment explaining what is returned by the functions. (I.e. that 0 means that it is a real device, not a file. Also if it is the total number of frames in the file or the remaining number of frames.)

@nylocx
Copy link
Author

nylocx commented Aug 11, 2014

I tried to adjust the patch according to your comment.

@taketwo
Copy link
Member

taketwo commented Aug 12, 2014

I think there are still spaces missing in the header file. When you fix it please also squash the commits so we get a clean history. Thanks!

This new functions can be used to determin the end of an .one file stream.

Adjusted frame count fix to meet pcl styleguide.

Missing spaces
@nylocx
Copy link
Author

nylocx commented Aug 12, 2014

Ok, yeah missed the header spaces, btw. is there a good reason for this coding style with spaces after functions? I have not seen that very often.

@taketwo
Copy link
Member

taketwo commented Aug 12, 2014

I guess it was a random choice made by the founder of the library. Yeah, it's not very common and certainly makes maintainer's life harder :)

taketwo added a commit that referenced this pull request Aug 12, 2014
Added functions to query depth, ir and color frame count.
@taketwo taketwo merged commit e121b2a into PointCloudLibrary:master Aug 12, 2014
@jpapon
Copy link
Contributor

jpapon commented Aug 12, 2014

Spaces after functions isn't random, it's part of the GNU coding standards =)

Also, be careful, Radu might be listening!

@nylocx nylocx deleted the frameCountFix branch August 13, 2014 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants