USC: fixed parameters / added descriptor-type #856
Conversation
| //inline void | ||
| //setAzimuthBins (size_t bins) { azimuth_bins_ = bins; } | ||
| // inline void | ||
| // setAzimuthBins (size_t bins) { azimuth_bins_ = bins; } |
There was a problem hiding this comment.
Can you either leave this as is or remove it completely in an extra commit?
There was a problem hiding this comment.
I've removed the lines.
Jens
----- Ursprüngliche Mail -----
Von: "Jochen Sprickerhof" notifications@github.com
An: "PointCloudLibrary/pcl" pcl@noreply.github.com
CC: "Jens Garstka" github@webart-factory.de
Gesendet: Dienstag, 19. August 2014 13:53:38
Betreff: Re: [pcl] USC: fixed parameters / added descriptor-type (#856)
} virtual ~UniqueShapeContext() { }
//inline void//setAzimuthBins (size_t bins) { azimuth_bins_ = bins; }// inline void// setAzimuthBins (size_t bins) { azimuth_bins_ = bins; }
Can you either leave this as is or remove it completely in an extra commit?
Reply to this email directly or view it on GitHub:
https://github.com/PointCloudLibrary/pcl/pull/856/files#r16409521
|
Hi Jens, we need you to clean up (squash) the commits in this pull request. |
Fixed the descriptor parameters matching the values of the original paper (Tombari et al. 2010). The former values have been copied from 3DSC-descriptor and have not been adapted. Added a descriptor type UniqueShapeContext1960. Modified test case to match the new UniqueShapeDescriptor.
|
@fedassa any comments? Otherwise I'm fine with merging. |
|
just checked: please go ahead. |
USC: fixed parameters / added descriptor-type
Fixed the descriptor parameters matching the values of the original
paper (Tombari et al. 2010). The former values have been copied from
3DSC-descriptor and have not been adapted.
Added a descriptor type UniqueShapeContext1960.