Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact representation - Stereo Matching algorithm #878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compact representation - Stereo Matching algorithm #878

wants to merge 1 commit into from

Conversation

jilliam
Copy link

@jilliam jilliam commented Aug 29, 2014

No description provided.

@jilliam
Copy link
Author

jilliam commented Aug 30, 2014

Hi @taketwo! Can you have a look on this error?
It seems that I'm having the same error as #875.

@taketwo taketwo added this to the pcl-1.8.0 milestone Sep 5, 2014
@taketwo taketwo removed this from the pcl-1.8.0 milestone Oct 11, 2015
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.9.0 milestone Aug 22, 2016
@taketwo taketwo added the needs: code review Specify why not closed/merged yet label Jun 30, 2017
@SergioRAgostinho
Copy link
Member

Sorry for the three year delay! Would you mind rebasing this to the current master?

@SergioRAgostinho SergioRAgostinho added needs: author reply Specify why not closed/merged yet changelog: new feature Meta-information for changelog generation and removed needs: code review Specify why not closed/merged yet labels Nov 22, 2017
@stale
Copy link

stale bot commented Jan 21, 2018

This pull request has been automatically marked as stale because it hasn't had
any activity in the past 60 days. Commenting or adding a new commit to the
pull request will revert this.

Come back whenever you have time. We look forward to your contribution.

@stale stale bot added the status: stale label Jan 21, 2018
@SergioRAgostinho SergioRAgostinho removed this from the pcl-1.9.0 milestone Jan 25, 2018
@stale stale bot removed the status: stale label Jan 25, 2018
@jilliam
Compact representation - Stereo Matching algorithm included
c15f2d3 
Compact representation - Stereo Matching algorithm included
@jilliam
Copy link
Author

jilliam commented Mar 4, 2018

Done! What should I do now?

@SergioRAgostinho SergioRAgostinho added needs: code review Specify why not closed/merged yet and removed needs: author reply Specify why not closed/merged yet labels Mar 4, 2018
@SergioRAgostinho
Copy link
Member

👍 thanks. Good to have you back.

  1. You need to add unit tests, to validate the new feature.
  2. (Optional) A tutorial with some images showcasing functionality would be really cool!
  3. Wait for our review.

@SergioRAgostinho SergioRAgostinho added module: stereo needs: more work Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Mar 4, 2018
@stale
Copy link

stale bot commented May 3, 2018

This pull request has been automatically marked as stale because it hasn't had
any activity in the past 60 days. Commenting or adding a new commit to the
pull request will revert this.

Come back whenever you have time. We look forward to your contribution.

@stale stale bot added the status: stale label May 3, 2018
@stale
Copy link

stale bot commented Feb 21, 2020

This pull request has been automatically marked as stale because it hasn't had
any activity in the past 60 days. Commenting or adding a new commit to the
pull request will revert this.

Come back whenever you have time. We look forward to your contribution.

@kunaltyagi kunaltyagi removed the stale label Feb 27, 2020
@stale stale bot removed the status: stale label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: new feature Meta-information for changelog generation module: stereo needs: more work Specify why not closed/merged yet status: stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilliam @SergioRAgostinho @taketwo @kunaltyagi