Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RobotEyeGrabber class to handle new packet format #982

Merged
merged 1 commit into from
Nov 6, 2014

Conversation

samontab
Copy link
Contributor

@samontab samontab commented Nov 3, 2014

Update RobotEyeGrabber to handle dynamic packet sizes, as well as a new header that includes time stamps.

@taketwo
Copy link
Member

taketwo commented Nov 3, 2014

Hi, thanks for the contribution. Could you please format your patch according to the PCL style guide?

@samontab
Copy link
Contributor Author

samontab commented Nov 5, 2014

@taketwo I made the suggested changes.

PD: For some reason Travis keeps saying:
"clang: error: unable to execute command: Killed" when compiling with clang.
It seems to be a project setting issue instead of code because all the pull requests since 5 months ago are not being correctly built. This may be a bit off topic, but it affects all current pull requests.

@taketwo
Copy link
Member

taketwo commented Nov 5, 2014

Thanks. Could you also squash the commits into one so that we have a clean history?

Yes, Travis fails almost every time in the recent months. This is certainly misleading, however so far we do not have a clean solution to the problem. Increasing the number of threads for compilation makes it likely that the server will choke, whereas reducing the number of threads makes it likely that we run out of 50 minutes limit...

@samontab
Copy link
Contributor Author

samontab commented Nov 6, 2014

@taketwo
Now there is only one commit for this pull request, and Travis behaved itself this time.

taketwo added a commit that referenced this pull request Nov 6, 2014
Update RobotEyeGrabber class to handle new packet format
@taketwo taketwo merged commit 2ca296b into PointCloudLibrary:master Nov 6, 2014
@taketwo
Copy link
Member

taketwo commented Nov 6, 2014

Great! Thanks for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants