Fixed issues when including Polaris in an external CMake project. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es(). target_include_directories() has the benefit of attaching the include directory to the public API of the library. That way, when someone adds the library as a target_link_libraries() dependency to their own project, it automatically adds the Polaris client source directory to the include path.
|
@anathan FYI. Also heads up that the Bazel builds are still broken because of an issue with boring-ssl. I believe you were working on a fix for that? |
Keeping BUILD_EXAMPLES support for backwards compatibilty for now.
When Polaris client is included in an external project, CMAKE_SOURCE_DIR will reflect the root directory of the external project.
CMake 3.5 and earlier are deprecated and CMake plans to remove compatibility for them in a future update (it has not been removed as of 3.27). 3.16 was first released in 2019, so it should be old enough now that it's a reasonable choice for a minimum requirement.
We need some changes from this branch to use FetchContent, so we can't reference the 1.3.1 release until it has been tagged.
adamshapiro0
force-pushed
the
cmake-build
branch
from
7f80389
to
90ced33
Compare
I'll open an issue to track that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Changes
BUILD_EXAMPLESoption toPOLARIS_BUILD_EXAMPLESFetchContent_MakeAvailable()Fixes
target_include_directories()calls to add source directories to include search pathCMAKE_MODULE_PATHwhen building out of tree