Fixed connection hang, segfault, and unexpected warnings issues after internet connection loss.

.bazelrc

@@ -16,3 +16,10 @@ build:aarch64 --spawn_strategy=local
 # instead of:
 # bazel build -c opt --//c:polaris_enable_tls=False //:polaris_client
 #build --flag_alias=polaris_enable_tls=//c:polaris_enable_tls
+
+# Enable address sanitizer (ASAN).
+#
+# When using, you may also wish to disable optimizations (`-c dbg` or
+# `--copt=-O0`). This may significantly impact performance, but may be
+# necessary to pinpoint certain errors in highly optimized sections of code.
+build:asan --copt=-g --copt=-fsanitize=address --linkopt=-fsanitize=address --linkopt=-static-libasan

bazel/repositories.bzl

@@ -55,13 +55,8 @@ def dependencies():
  maybe(
  git_repository,
  name = "boringssl",
- commit = "87f3087d6343b89142d1191388a5885d74459df2",
- # Patch out -Werror to avoid error on GCC 11. The new warning that is
- # triggering an error is a conversion between `const uint8_t s[32]` and
- # `const uint8_t *s` in curve25519.c (-Werror=array-parameter=).
- patch_args = ["-p1"],
- patches = ["boringssl.patch"],
- # 2020/4/7
+ # 2024/3/25
+ commit = "54f64295218630fd869b3a079d9dfb5abfe61324",
  remote = "https://boringssl.googlesource.com/boringssl",
- shallow_since = "1586306564 +0000",
+ shallow_since = "1711401451 +0000",
  )

c/.bazelrc

@@ -0,0 +1,6 @@
+# Enable address sanitizer (ASAN).
+#
+# When using, you may also wish to disable optimizations (`-c dbg` or
+# `--copt=-O0`). This may significantly impact performance, but may be
+# necessary to pinpoint certain errors in highly optimized sections of code.
+build:asan --copt=-g --copt=-fsanitize=address --linkopt=-fsanitize=address --linkopt=-static-libasan

c/CMakeLists.txt

@@ -48,7 +48,8 @@ endif()
 # Polaris client C library - all messages and supporting code.
 add_library(polaris_client
  src/point_one/polaris/polaris.c
- src/point_one/polaris/polaris_internal.c)
+ src/point_one/polaris/polaris_internal.c
+ src/point_one/polaris/portability.c)
 target_include_directories(polaris_client PUBLIC ${PROJECT_SOURCE_DIR}/src)
 if (MSVC)
  target_compile_definitions(polaris_client PRIVATE BUILDING_DLL)

c/Makefile

@@ -1,7 +1,8 @@
 SRC_DIR=src
 
 SOURCES=$(SRC_DIR)/point_one/polaris/polaris.c \
- $(SRC_DIR)/point_one/polaris/polaris_internal.c
+ $(SRC_DIR)/point_one/polaris/polaris_internal.c \
+ $(SRC_DIR)/point_one/polaris/portability.c
 
 OBJECTS=$(patsubst %.c,%.o,$(SOURCES))
 

c/bazel/repositories.bzl

@@ -23,13 +23,8 @@ def dependencies():
  maybe(
  git_repository,
  name = "boringssl",
- commit = "87f3087d6343b89142d1191388a5885d74459df2",
- # Patch out -Werror to avoid error on GCC 11. The new warning that is
- # triggering an error is a conversion between `const uint8_t s[32]` and
- # `const uint8_t *s` in curve25519.c (-Werror=array-parameter=).
- patch_args = ["-p1"],
- patches = ["boringssl.patch"],
- # 2020/4/7
+ # 2024/3/25
+ commit = "54f64295218630fd869b3a079d9dfb5abfe61324",
  remote = "https://boringssl.googlesource.com/boringssl",
- shallow_since = "1586306564 +0000",
+ shallow_since = "1711401451 +0000",
  )

c/examples/simple_polaris_client.c

@@ -28,13 +28,23 @@ void HandleSignal(int sig) {
 int main(int argc, const char* argv[]) {
  if (argc < 2 || argc > 4) {
  P1_fprintf(stderr,
- "Usage: %s API_KEY [UNIQUE_ID] [LOG_LEVEL (1=debug, 2=trace)]\n",
+ "Usage: %s API_KEY UNIQUE_ID [LOG_LEVEL (1=debug, 2=trace)]\n",
  argv[0]);
  return 1;
  }
 
  const char* api_key = argv[1];
- const char* unique_id = argc > 2 ? argv[2] : "device12345";
+ if (strlen(api_key) == 0) {
+ P1_fprintf(stderr,
+ "You must supply a Polaris API key to connect to the server.\n");
+ return 1;
+ }
+
+ const char* unique_id = argv[2];
+ if (strlen(unique_id) == 0) {
+ P1_fprintf(stderr, "You must supply a unique ID for this connection.\n");
+ return 1;
+ }
 
  int log_level = argc > 3 ? atoi(argv[3]) : POLARIS_LOG_LEVEL_INFO;
  Polaris_SetLogLevel(log_level);
@@ -66,6 +76,7 @@ int main(int argc, const char* argv[]) {
  // Send a position update to Polaris. Position updates are used to select an
  // appropriate corrections stream, and should be updated periodically as the
  // receiver moves.
+ P1_printf("Setting initial position.\n");
  if (Polaris_SendLLAPosition(&context, 37.773971, -122.430996, -0.02) !=
  POLARIS_SUCCESS) {
  Polaris_Disconnect(&context);
@@ -80,9 +91,10 @@ int main(int argc, const char* argv[]) {
  signal(SIGTERM, HandleSignal);
 
  Polaris_Run(&context, 30000);
- Polaris_Free(&context);
 
- P1_printf("Finished.\n");
+ P1_printf("Finished running. Cleaning up.\n");
+ Polaris_Free(&context);
 
+ P1_printf("Exiting.\n");
  return 0;
 }