Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests on GH Actions #30

Merged
merged 8 commits into from
Aug 1, 2021
Merged

Add unit tests on GH Actions #30

merged 8 commits into from
Aug 1, 2021

Conversation

Naramsim
Copy link
Member

@Naramsim Naramsim commented Jul 27, 2021

Travis-ci has switched from .org to .com so I thought we could get rid of it and start using Actions.

So this PR tests Pokebase on Python 3.6 and 3.7 on Actions.

@Naramsim Naramsim requested review from GregHilmes and Kronopt July 27, 2021 18:10
@Davidy22
Copy link
Contributor

Davidy22 commented Jul 31, 2021

I enabled 3.8 and 3.9 on my branch that has a bunch of dependency version bumps and the check passed. My pull request that contains version bumps has been merged, so this probably works if you pull from main and try 3.8 again.

Copy link
Member

@Kronopt Kronopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Naramsim
Copy link
Member Author

Naramsim commented Aug 1, 2021

I've added a job for checking the syntax with flake8

@Naramsim Naramsim merged commit f634eb4 into master Aug 1, 2021
@clot27
Copy link

clot27 commented Aug 9, 2021

hey can anybody help me with how can i print the stats of a given pokemon? (sorry for dumb question)

@Naramsim
Copy link
Member Author

Naramsim commented Aug 9, 2021

@aditya-yadav-27

import pokebase as pb

for stat in pb.pokemon('charmander').stats:
  print('{}: {}'.format(stat.stat.name, stat.base_stat))

https://replit.com/@AlessandroPezze/OpulentUtilizedAudit#main.py

@clot27
Copy link

clot27 commented Aug 12, 2021

does searching pokemon from its id is not working?

@Davidy22
Copy link
Contributor

For one, you probably want to open an issue for this instead of post in a closed pull request. Also, can you provide the code that doesn't work for you so we can see what's happening?

@clot27
Copy link

clot27 commented Sep 2, 2021

k sorry for that btw I can't understand how to print the evolution line of a pokemon can anyone help me with this?

@PokeAPI PokeAPI locked as off-topic and limited conversation to collaborators Sep 2, 2021
@Naramsim Naramsim deleted the gh-action branch December 13, 2023 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants