-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Feature] added keep pokemon for batch evolution (#2255)
* added keep_for_evo * accounted for non evolable pokemon * additional logging * additional logging * moved get_candies to utils * disregard 2nd stage evolution pokemon * added sample configs
- Loading branch information
1 parent
550b2c3
commit ea42eac
Showing
5 changed files
with
98 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bot just released my best pokemon and my config is the same:
I don't konw if it's this PR but it's my best guess.
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this.
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielVolz Have you just copied and pasted the example config.json?
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KLVN no, I used my "old" one. Some commits before this PR.
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@douglascamata man you're fast ;). Thanks for the great work!
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine for me. Curious to hear what the issue is. :)
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is painful. I'm so scared now.
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@g2384 tell me about it :(
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already reverted this.
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that this also contributed to
[14:28:11] Exchanging Vaporeon [CP 1250] [Potential 0.8] for candy!
[14:28:14] Exchanging Snorlax [CP 1757] [Potential 0.89] for candy!
Everyone needs to be more alert about transfer_pokemon changes now.
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would disable every option that could result in transfers and set release_configs to
0
, so users have to change it by themselves and are aware ofconfig.json
and what it does. Also it's their own fault if they set wrong values.ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KLVN I had config set very specifically
"any": {"keep_best_iv": 2, "release_below_cp": 1000, "release_below_iv": 0.8, "logic": "or"},
"Snorlax": { "release_below_cp": 0, "release_below_iv": 0.8, "logic": "and" }.
That Snorlax or Vaporeon does not meet any of those rules...Even worse, the commit also removed the log output on why a Pokemon was removed so there is no way to know why it happened.
That commit just ignored the config altogether.
If previous commit doesn't release Pokemons, and suddenly out of nowhere a new commit just start releasing pokemons on the same config, the user can't do much about it except being paranoid and careful about
dev
branch, commenting out the Release api call and dry-run it first before actually doing any release api call.Honestly, a dry-run option for this may not be a bad idea since it deals with an irreversible change happening once on startup, so user has an option to test their release rules between
git pull
or config changes.ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A way to test the configs would be great. A dry-run so the bot outputs
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or an optional prompt that asks every time before a Pokemon will be released/transferred.
"tasks": [ { "type": "PromptBeforeTransfer" }
Snorlax [CP 1757] [Potential 0.89] matches criteria {rule here}. Release? (y/n)
ea42eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will require supervision though. Think knowing why and ability to dry-run after
git pull
would be enough.