Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest dev, no release #1230

Closed
J-o-h-n-M opened this issue Jul 27, 2016 · 11 comments
Closed

latest dev, no release #1230

J-o-h-n-M opened this issue Jul 27, 2016 · 11 comments

Comments

@J-o-h-n-M
Copy link

J-o-h-n-M commented Jul 27, 2016

Expected Behavior

I expect to have pokemons released at startup (value is 850) old bot would release all lower then 850. But also during catching i expect them to be released under 500 or 0.8. Nut nothing is released at all

My config (leaving out the credentials)

   "max_steps": 5,
    "mode": "all",
    "walk": 4.01,
    "debug": false,
    "test": false,
    "initial_transfer": 850,
    "location_cache": false,
    "distance_unit": "km",
    "reconnecting_timeout": 15,
    "item_filter": {
      "1": { "keep" : 100 },
      "101": { "keep" : 10 },
      "102": { "keep" : 10 },
      "103": { "keep" : 10 },
      "103": { "keep" : 10 },
      "201": { "keep" : 10 },
      "701": { "keep" : 20 }
    },
    "evolve_all": "NONE",
    "evolve_speed": 20,
    "cp_min": 500,
    "use_lucky_egg": false,
    "evolve_captured": false,
    "catch": {
      "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"}
    },
    "release": {
        "any": {"release_under_cp": 500,"release_under_iv": 0.8, "cp_iv_logic": "and"},                     
    "exceptions": {
        "always_capture": [
            "Arcanine",
            "Lapras",
            "Dragonite",
            "Snorlax",
            "Blastoise",
            "Moltres",
            "Articuno",
            "Zapdos",
            "Mew",
            "Mewtwo"
        ]
    }
    }
}

image

Actual Behavior

nothing is released at start or during catching

Steps to Reproduce

start latest dev

Other Information

OS: Windows
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

@KLVN
Copy link
Contributor

KLVN commented Jul 27, 2016

Check your release_config.json

@J-o-h-n-M
Copy link
Author

i am on latest dev, no release_config.json anymore in there

@bimahp
Copy link
Contributor

bimahp commented Jul 27, 2016

Can you try to change "cp_iv_logic": "and" to "cp_iv_logic": "or" ?

@J-o-h-n-M
Copy link
Author

J-o-h-n-M commented Jul 27, 2016

changed it to or, same result. It should be 'and' the rattata in the first print is under 500 AND under 0.8. So should be released

this is when set to 'or'
image

@KLVN
Copy link
Contributor

KLVN commented Jul 27, 2016

i am on latest dev, no release_config.json anymore in there

whoops... Pepperidge Farm remembers 😄

@matrix14
Copy link

change cp_min to 850

@glennvgastel
Copy link
Contributor

In dev, cp_min was changed to release_under_cp , but I can confirm this is currently not working. Neither is transferring at start, etc. I guess it's all related.

@bimahp
Copy link
Contributor

bimahp commented Jul 27, 2016

actually its now "release_below_cp" and "release_below_iv" as seen on example
just give it a shot

@glennvgastel
Copy link
Contributor

@bimahp Thanks, damn these subtle changes! xD

@valerian
Copy link
Contributor

valerian commented Jul 27, 2016

The problem is that now the initial release is tied to the farming/catching release rules, I liked to be able to clean up all low CP pokemons when I restart the script (every hour).
I did a little edit to the code to have an initial category in the release rules, which is a global rule like any but is only taken in account in initial_transfer_worker.py, and has the highest priority.

Or maybe it's completely useless and there is something that I don't understand in the way I'm supposed to use the dev branch?

@valerian
Copy link
Contributor

I think this feature will provide a different way to do a kind of similar result, I really like it: #1395

hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this issue Sep 28, 2016
Just a minor edit to keep it true... ;-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants