Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walking in a loop in "catch" mode #1238

Closed
vicch opened this issue Jul 27, 2016 · 6 comments
Closed

Walking in a loop in "catch" mode #1238

vicch opened this issue Jul 27, 2016 · 6 comments
Labels

Comments

@vicch
Copy link

vicch commented Jul 27, 2016

Expected Behavior

Walking in "catch" mode should more efficient (towards lures, for example), or at least more unpredictable.

Actual Behavior

Walking repeatedly in a path shaped like a "9", which is inefficient and unnatural. See screenshot:

1

Steps to Reproduce

Just run and wait for the "catch" mode to start.
I have tried in different locations, so should have no relation to the starting point.

Other Information

OS: Windows 7
Git Commit: 74e37de

@smith-and-web
Copy link

I run the bot in Halifax sometimes and haven't noticed that behaviour.

@vicch
Copy link
Author

vicch commented Jul 27, 2016

@smith-and-web OK, you found me :) But have you tried the latest dev ? I don't remember seeing this behavior before either.

@koppa
Copy link

koppa commented Jul 27, 2016

In dev this behavior is still there. I'm running the latest version.

@vicch
Copy link
Author

vicch commented Jul 27, 2016

A simple solution is to keep your bag far from full, so that it stays in "all" mode.

@smith-and-web
Copy link

I take it back, I got stuck around pizza corner.

@vicch
Copy link
Author

vicch commented Jul 29, 2016

Not seen since yesterday, maybe fixed.

@vicch vicch closed this as completed Jul 29, 2016
hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this issue Sep 28, 2016
…okemonGoF#1238)

* Revert "Rename credentials.example.json to credentials.json (PokemonGoF#1098)"

This reverts commit 100ff5d.

* Handle credentials.json not existing

Properly handle the case where credentials.json does not exist
and default the loaded credentials to an empty dictionary instead.

Also use get instead of a direct key lookup to provide a default value
to check against.
hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this issue Sep 28, 2016
Readded rename line, to fix for PR PokemonGoF#1238
hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this issue Sep 28, 2016
Currently the info window for Pokémon, Gyms, etc. can only be closed with the little x. This adds a stateful click handler that closes the info window with a second click.
Implements PokemonGoF#1237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants