-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Bot loops around min_ball in MovetoMapPokemon task #4675
Comments
Not sure why we check pokeballs three times in the work function. I'm looking into the fix, but I want to make sure I know what's going on in this file first. |
If you could give #4684 a try. Should fix the issue. |
Thanks a lot, I pulled your PR ( I will update once I hit |
Yep, switched over perfectly. Nicely done. Thanks a lot bud. Updated Log
|
Perfect. Glad to help @Vvkmnn |
Hey, the primary issue of not having enough balls and losing the pokemon is still resolved, but I've noticed the bot will stop sniping once it hits Here's a log example with
Basically it seems to be doing the same thing it did with the 1 you fixed in f52b693 with I currently use a temporary fix by setting I'm wondering if that logic can be translated into a jew parameter calling
With a start check that compares with
So it cycles through the quantities until its hits the min, then only restarts after its over the max. I'm not sure if that's right; I'm still trying to get the hang of Python, and I'm still unfamiliar with the internals of this bot. What do you think? |
I'd say set min_ball to some sort of medium value. Enough you won't not catch pokemon but low enough you'll not avoid catching them for extended periods. |
Fair enough, I'll try that. |
@Vvkmnn If you feel you would like some additional features added to accomplish what you're looking for, could you open a new issue? I'm going to close for now, if you want to let me know how my recommendation worked, you can reply without reopening. Thanks! |
Yep, my bad. Thought I closed this. I'll reopen a new one sometime. Cheers guys. |
Expected Behavior
The bot will only start sniping after it has a minimum number of balls, as defined by
min_ball
.Actual Behavior
Bot will start sniping as soon as it has even one pokeball, and is forced to flee because it runs out of balls.
Config:
Log
Steps to Reproduce
In the
MoveToMapPokemon
task, you can set"min_ball"
to whatever and it just seems to ignore it.OS: OSX 10.10.5
Branch: dev
Git Commit: bda706a
Python Version: Python 2.7.12
The text was updated successfully, but these errors were encountered: