Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PokemonOptimizer it says Evolving the best, but apparently not #5492

Closed
liejuntao001 opened this issue Sep 16, 2016 · 12 comments
Closed

PokemonOptimizer it says Evolving the best, but apparently not #5492

liejuntao001 opened this issue Sep 16, 2016 · 12 comments
Assignees

Comments

@liejuntao001
Copy link

Your FULL config.json (remove your username, password, gmapkey and any other private info)

   {
        "type": "PokemonOptimizer",
        "config": {
            "enabled": true,
            "min_slots_left": 5,
            "transfer": true,
            "transfer_wait_min": 4,
            "transfer_wait_max": 6,
            "evolve": true,
            "evolve_time": 25,
            "evolve_for_xp": false,
            "evolve_only_with_lucky_egg": false,
            "evolve_count_for_lucky_egg": 72,
            "may_use_lucky_egg": false,
            "upgrade": true,
            "upgrade_level": 60,
            "groups": {
                "gym": ["Dragonite", "Snorlax", "Lapras", "Arcanine"],
                "my_love": ["Pikachu"],
                "vip": ["Exeggutor", "Gyarados", "Poliwrath", "Vaporeon", "Muk", "Venusaur", "Victreebel", "Dragonite", "Snorlax", "Lapras", "Arcanine", "Flareon", "Magmar", "Slowbro", "Machamp", "Blastoise", "Charizard", "Nidoqueen", "Vileplume"]
            },
            "rules": [
                {
                    "mode": "by_pokemon",
                    "names": ["vip"]
                },
                {
                    "mode": "by_family",
                    "top": 1,
                    "sort": ["iv"],
                    "evolve": {"iv": 0.9}
                },
                {
                    "mode": "by_family",
                    "top": 1,
                    "sort": ["ncp"],
                    "evolve": {"ncp": 0.9}
                },
                {
                    "mode": "by_family",
                    "top": 1,
                    "sort": ["cp"]
                },
                {
                    "mode": "by_family",
                    "names": ["my_love"]
                }
            ]
        }
    },

Output when issue occurred

[2016-09-16 15:34:09] [PokemonGoBot] [INFO] #4 Charmander[2][30 candies]: (CP 507, IVCP 0.18, DPS 12.16, Moves: [Ember, Flamethrower]) | (CP 330, IVCP 0.41, DPS 15.12, Moves: [Scratch, Flamethrower])
[2016-09-16 15:34:09] [PokemonGoBot] [INFO] #14 Kakuna[1][57 candies]: (CP 259, IVCP 0.81, DPS 9.83, Moves: [Bug Bite, Struggle])

[2016-09-16 15:49:24] [PokemonOptimizer] [INFO] Evolving 25 Pokemon (the best)
[2016-09-16 15:49:24] [PokemonOptimizer] [INFO] Evolved Charmander [IV 0.24] [CP 507] [6 candies] [+1000 xp]
[2016-09-16 15:49:47] [PokemonOptimizer] [INFO] Evolved Kakuna [IV 0.84] [CP 259] [8 candies] [+1000 xp]
^C[2016-09-16 15:50:02] [PokemonGoBot] [INFO] Bot caught SIGINT. Shutting down.

Branch:
master
Git Commit:
a8ee312

@julienlavergne
Copy link
Contributor

I don't see any error in your config or in the log. What is the problem ?

@liejuntao001
Copy link
Author

liejuntao001 commented Sep 17, 2016

my rules should only evolve iv > 0.9 or ncp > 0.9
it was like that before but the new master branch did evolve the
Charmander iv 0.24
Kakuna iv 0.84
in the "Evolving the best" part

@julienlavergne
Copy link
Contributor

Strange, it does not look like their ncp is greater than 0.9 either. Do you have really full log of that session ?

@liejuntao001
Copy link
Author

full log has been flushed
in that session the special thing was
"evolve_for_xp": false,
"may_use_lucky_egg": false,

@Plotin
Copy link

Plotin commented Sep 20, 2016

Same here, I just noticed this in the log, apparently, the optimizer is sending away better ones and then evolves one of the rest. Also, it does not really evolve for XP at the moment. The bot has about 200 Pidgey candies but instead of using them, it sends Pidgeys away all the time. Same with Zubats, Ratattas etc. I do not use lucky eggs, so the bot does not need to wait for anything, in my opinion, it should evolve every Pidgey it possibly can.

[2016-09-20 07:22:53] [PokemonOptimizer] [INFO] Pokemon Bag: 245/250
[2016-09-20 07:22:53] [PokemonOptimizer] [INFO] Transferring 2 Pokemon
[2016-09-20 07:22:55] [PokemonOptimizer] [INFO] Exchanged Drowzee [IV 0.53] [CP 356] [49 candies]
[2016-09-20 07:22:58] [PokemonOptimizer] [INFO] Exchanged Drowzee [IV 0.47] [CP 652] [50 candies]
[2016-09-20 07:23:03] [PokemonOptimizer] [INFO] Evolving 1 Pokemon (the best)
[2016-09-20 07:23:03] [PokemonOptimizer] [INFO] Evolved Drowzee [IV 0.31] [CP 13] [1 candies] [+500 xp]

My config looks like this:

{
"type": "PokemonOptimizer",
"config": {
"enabled": true,
"min_slots_left": 5,
"transfer": true,
"transfer_wait_min": 3,
"transfer_wait_max": 5,
"evolve": true,
"evolve_time": 25,
"evolve_for_xp": true,
"evolve_only_with_lucky_egg": false,
"evolve_count_for_lucky_egg": 80,
"may_use_lucky_egg": false,
"upgrade": false,
"upgrade_level": 60,
"groups": {
"gym": ["Dragonite", "Snorlax", "Lapras", "Arcanine"],
},
"rules": [
{
"mode": "by_family",
"top": 1,
"sort": ["iv"],
"evolve": {"iv": 0.9}
},
{
"mode": "by_family",
"top": 1,
"sort": ["ncp"],
"evolve": {"ncp": 0.9}
},
{
"mode": "by_family",
"top": 1,
"sort": ["cp"]
},
{
"mode": "by_family",
"top": 1,
"sort": ["dps_attack"]
},
{
"mode": "by_family",
"top": 3,
"names": ["gym"],
"sort": ["iv", "ncp"],
"evolve": {"iv": 0.9, "ncp": 0.9},
"upgrade": {"iv": 0.9, "ncp": 0.9}
}
]
}
},

@julienlavergne
Copy link
Contributor

@Plotin Do you have details of what is in your bag when you get that log ? Also, what are the next lines you get after that log ?

@ALL It is easier for me to see something if you don't cut the logs. Just out everything you have. Also it is good if I can see your inventory, for example with the inventory.json file dumped in the web folder

@Plotin
Copy link

Plotin commented Sep 20, 2016

@anakin5 Sorry, I don't have the logs after that incident any more bot the bot just went on botting, nothing more from PokemonOptimizer until the next encountered pokemon.
The inventory file was roughly like the attached one. The bot ran in the meantime but it is in a not so crowded area, so there may be 2-3 more pokemon than when that happened, but not too many changes

inventory.zip

Also, on another bot I get this:

[2016-09-20 08:11:55] [IncubateEggs] [INFO] Eggs incubating: [1.65/2.0 km](Eggs left: [%285.0, 1%29, %2810.0, 7%29], Incubating: 1)
[2016-09-20 08:11:56] [UpdateLiveInventory] [INFO] Pokemon: 250/250 | Items: 330/350 | Pokeballs: 5 | GreatBalls: 7 | UltraBalls: 145 | RazzBerries: 71 | LuckyEgg: 4
[2016-09-20 08:11:56] [ShowBestPokemon] [INFO] Best Pokemons (Snorlax, CP 2254, IVCP 0.81, DPS 15.11, HP 217/217) | (Dragonite, CP 2123, IVCP 0.72, DPS 12.94, HP 120/120) | (Flareon, CP 1792, IVCP 0.92, DPS 12.72, HP 94/94) | (Flareon,
CP 1716, IVCP 0.92, DPS 12.72, HP 91/91) | (Arcanine, CP 1696, IVCP 0.96, DPS 11.27, HP 116/116)
[2016-09-20 08:11:56] [PokemonOptimizer] [INFO] Pokemon Bag: 250 / 250
[2016-09-20 08:11:57] [ SpinFort] [INFO] Spun pokestop Grand Hotel Taschenbergpalais. Experience awarded: 50. Items awarded: 1x Ultraball, 1x Greatball, 1x Hyper Potion
[2016-09-20 08:12:01] [MoveToFort] [INFO] Moving towards pokestop Waschbrettbauch-Atlanten mit S - 0.07km
....
[2016-09-20 08:13:46] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:13:46] [MoveToFort] [INFO] Moving towards pokestop Springbrunnen - Zwingerecke - 0.04km
[2016-09-20 08:13:47] [ SpinFort] [INFO] Spun pokestop Springbrunnen - Zwingerecke. Experience awarded: 50. Items awarded: 3x Pokeball
[2016-09-20 08:13:56] [ItemRecycler] [INFO] Discarded 9x Pokeball.
[2016-09-20 08:14:00] [ItemRecycler] [INFO] Discarded 3x Greatball.
[2016-09-20 08:14:03] [ItemRecycler] [INFO] Discarded 3x Potion.
[2016-09-20 08:14:07] [ItemRecycler] [INFO] Discarded 1x Super Potion.
[2016-09-20 08:14:07] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:07] [MoveToFort] [INFO] Moving towards pokestop Mnemosyne - 0.06km
[2016-09-20 08:14:09] [IncubateEggs] [INFO] Eggs incubating: [1.66/2.0 km](Eggs left: [%285.0, 1%29, %2810.0, 7%29], Incubating: 1)
[2016-09-20 08:14:09] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:11] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:13] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:13] [MoveToFort] [INFO] Moving towards pokestop Mnemosyne - 0.05km
[2016-09-20 08:14:14] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:15] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:17] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
[2016-09-20 08:14:18] [PokemonCatchWorker] [INFO] Your Pokemon inventory is full! Could not catch!
....

Inventory for this bot:
inventory2.zip

Config is the same as the other one.

Hope that helps! Thanks for the great work you guys do!

@julienlavergne
Copy link
Contributor

julienlavergne commented Sep 20, 2016

@Plotin
Your 2 issues are normal behavior.

Case 1:
There is no any Pidgey in your inventory. So it does not matter how much candies you have if there is none to evolve.
The 2 Drowzee exchanged are neither best iv not best ncp nor best cp nor best dps_attack. The one evolved is best dps_attack. So it matches your configuration. (You have an Hypno 1.0 and an Hypno cp 1474).
The Drowzee best dps attack has been exchanged afterwards since its moved have been rerolled to some other bad ones. It is not really advised to apply dps_attack rule on other things than final evolution.

Case 2:
Very easy case, there is no Pokemon in the bag that do not match at least one of the rules. So there is nothing to exchange. You might want to change your rules a bit to keep less Pokemon.

@liejuntao001
There is an error in the doc and config example. The evolve parameter is true by default so your best cp get evolved. I will rectify and add the evolve: false to the rules where it was not present.

@Plotin
Copy link

Plotin commented Sep 20, 2016

@anakin5

Case 1: Could you please explain why Pidgeys are not evolved then? My understanding would be, that if the bot catches a Pidgey and is short of bag space, it should evolve it, then send the Pidgetto (or whatever it is called) away. Instead, it gets sends the Pidgey away accumulating candy. Can the described behaviour be accomplished somehow?

Case 2: Why does the bot not get rid of one of the 10 Raticates or the 20+ Drowzees? The rules say to keep only the best by iv, the best by cp, the best by ncp and the best by dps...that makes 4, or am I misinterpreting the config?

@julienlavergne
Copy link
Contributor

@Plotin
To avoid using candies for rare Pokemon,, the Pokemon we select for xp must weight 2% of your bag capacity (so 5 in your case). Since your bag is always full, the Pidgey get released as soon as it is caught to make some place. You never reach the 5 Pidgey in your bag that would be necessary to evolve them for xp.
This 2% rule is removed now that you can specify a list of Pokemon for the evolve_for_xp parameter.

For the case 2, as I said, all your Pokemon match at least one of your rule. Your 20+ Dowzees all have the same move and are all selected as best attack. Since they are equal, they are all kept.
Same for your Raticates, there is a lot with the same best moves.

@Plotin
Copy link

Plotin commented Sep 20, 2016

@anakin5 Ok, thanks for the clarification! Keep up the great work!

@julienlavergne
Copy link
Contributor

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants