Fix crash with upgrade pokemon #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBa2016
reviewed
Sep 20, 2016
| for i in range(pokemon.level, upgrade_level, 0.5): | ||
| upgrade_cost = self.pokemon_upgrade_cost[2 * (i - 1)] | ||
| for i in range(int(pokemon.level * 2), int(upgrade_level * 2)): | ||
| upgrade_cost = self.pokemon_upgrade_cost[i - 2] |
There was a problem hiding this comment.
what kind of crash is it fixing? I don't see any difference between old and new code - it looks exactly the same (steps are twice as big, but "*2" is omitted when the couner variable is used, so...)
Can you show the logfile with the crash?
There was a problem hiding this comment.
You cannot create a range with a decimal step
|
need the pull approve stuff otherwise I cannot merge :s. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When optimizer tried to transfer it crashes bot #5563 New Pokemon Optimizer crashes the Bot (Maybe because of buddy assignment) #5567 PokemonOptimizer stops after counting pokemon in bag #5565 PokemonOptimizer it says Evolving the best, but apparently not #5492