Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix walking speed as suggested in #1586 #1649

Closed
wants to merge 1 commit into from
Closed

Fix walking speed as suggested in #1586 #1649

wants to merge 1 commit into from

Conversation

klingan
Copy link
Contributor

@klingan klingan commented Jul 29, 2016

Short Description: Fixes the slow speed of walking if evolve is turned on
Fixes:

  • Walking is at normal speed again instead of crawling

@douglascamata
Copy link
Member

douglascamata commented Jul 29, 2016 •
edited
Loading

@klingan what consequences does this patch have to EvolveAllWorker? I don't want to read that code, it's a complete mess and should be rewritten.

@mrseeker
Copy link

mrseeker commented Jul 29, 2016 •
edited
Loading

That it won't run constantly, only once (during game tick 0). If this setting is kept on True, it will keep itself running (and cause a huge lag).

@douglascamata
Copy link
Member

douglascamata commented Jul 29, 2016 •
edited
Loading

I'm inclined to no accept this. Because evolve_all can also be configured to evolve only certain pokemon, which would make it faster, and should also work if there's no lucky egg available....

@douglascamata
Copy link
Member

Also this worker shouldn't release pokemon... Oh, what a mess.

@bigkraig
Copy link
Contributor

not sure if its related, but checking on lucky eggs all of the time seems to be spamming my log

[15:47:50] No lucky eggs... skipping evolve!
[15:47:56] Moving towards fort 3e39a69af6e9439cb48dbfa1db080ca1.16, 0.16km left
[15:48:00] No lucky eggs... skipping evolve!
[15:48:06] Spinning ...
[15:48:06] Loot:
[15:48:06] 50 xp
[15:48:07] - 3x Pokeball (Total: 103)
[15:48:07] PokeStop on cooldown. Time left: 5 minutes, 28 seconds
[15:48:09] Moving towards fort 3e39a69af6e9439cb48dbfa1db080ca1.16, 0.14km left
[15:48:13] No lucky eggs... skipping evolve!
[15:48:14] -- Recycled 3x Pokeball (keeps only 100 maximum)
[15:48:20] Moving towards fort 3e39a69af6e9439cb48dbfa1db080ca1.16, 0.13km left
[15:48:24] No lucky eggs... skipping evolve!
[15:48:30] Moving towards fort 3e39a69af6e9439cb48dbfa1db080ca1.16, 0.11km left
[15:48:34] No lucky eggs... skipping evolve!
[15:48:40] Moving towards fort 3e39a69af6e9439cb48dbfa1db080ca1.16, 0.09km left
[15:48:45] No lucky eggs... skipping evolve!
[15:48:51] Moving towards fort 3e39a69af6e9439cb48dbfa1db080ca1.16, 0.08km left
[15:48:55] No lucky eggs... skipping evolve!

@douglascamata
Copy link
Member

WHO WANTS TO REFACTOR WHOLE EVOLVE LOGIC?!

@nburn42 nburn42 mentioned this pull request Jul 29, 2016
Closed
@BobbyWibowo
Copy link

Ah. That explains why my bot wouldn't move for minutes..

@mrseeker
Copy link

Fixed with pull #1774

hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this pull request Sep 28, 2016
@invisiblek @marauder37
Revert "Revert "Use a sprite for the pokemon on the map" (PokemonGoF#…
ca8f319 
…1640)" (PokemonGoF#1649)

* fix the logic for y

This reverts commit 5fff2fa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klingan @douglascamata @mrseeker @bigkraig @BobbyWibowo