Make logger work with both str and unicode #1824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log is sometimes called with str, other times with unicode sequences. This change makes it work for both cases.
|
Sorry about before, copy pasta fail. |
thedewil
referenced
this pull request
Jul 30, 2016
Displays the fort name in the CLI instead of the fort id. Easier to read, better to look at than a hash.
|
190640f makes this irrelevant |
|
@DayBr3ak Nope, I am still getting errors if the initial location contains any special characters. |
|
#1825 should fix the issue with the initial location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
log is sometimes called with str, other times with unicode sequences. This change makes it work for both cases.
Fixes: