Draft feature to snipe pokemon #1887

enjoy2000 · 2016-07-30T17:23:22Z

Short Description:
Add draft commit with hope that u guys can give me some advices.
Always got softbanned when trying to snipe pokemon.

douglascamata · 2016-07-30T17:49:20Z

What you mean by snipe?

enjoy2000 · 2016-07-30T17:51:47Z

Ah that word from .net version.

People can use trick to teleport to pokemon coords and encounter it then teleport back.
After that we can catch it normally without softban.

DayBr3ak · 2016-07-30T20:45:16Z

Yes apparently you have to start the fight and teleport back before throwing the first pokeball

wilsonyqm · 2016-07-31T02:37:24Z

Can you take a look at this PR #1748

enjoy2000 · 2016-07-31T03:39:09Z

./pokecli.py --snipe=True
First run and it success.

But maybe need more refactoring work, please help to review.

elicwhite · 2016-07-31T07:03:12Z

pokecli.py

@@ -104,6 +108,34 @@ def report_summary(bot):
    if metrics.most_perfect is not None:
        logger.log('Most Perfect Pokemon: {}'.format(metrics.most_perfect['desc']), 'cyan')

+def snipe():


This shouldn't be here. Now that the bot is fully configurable by the user in config.json, I'd recommend creating a SnipePokemon worker. Then a user could specify just that in their config.json and get the behavior you want. There should generally be no reason this file needs to be modified anymore.

enjoy2000 · 2016-07-31T08:20:27Z

@TheSavior Updated, please have a look again. Thanks.

nikhil-pandey · 2016-07-31T08:56:43Z

Awesome!

nikhil-pandey · 2016-07-31T08:58:53Z

Processing snipe targets from a configuration file on each tick would be awesome.

elicwhite · 2016-07-31T08:59:28Z

pokemongo_bot/cell_workers/snipe_pokemon.py

+from pokemongo_bot import logger
+from utils import distance
+
+class SnipePokemon(object):


This should extend BaseTask which gives you bot and config for free. Take a look at the other workers for an example

elicwhite · 2016-07-31T09:04:51Z

@douglascamata Please review this

elicwhite · 2016-07-31T09:16:31Z

pokemongo_bot/cell_workers/snipe_pokemon.py

+        if self.bot.tick_count is not 1:
+            return
+
+        while True:


This makes me super uncomfortable. I understand why it is here and what you are trying to do, but this is super yucky as a worker to have a while true that waits for user input. Perhaps @douglascamata's socket.io approach will be what we need to support this.

@TheSavior @enjoy2000 Or we could use a configuration file with list of snipe targets and process them one by one and remove the targets as they are processed. Would be usable even when bot is running. Similar to #1768

enjoy2000 · 2016-07-31T10:28:07Z

@TheSavior @douglascamata @nikhil-pandey is something like watchdog & a config file ok?

elicwhite · 2016-07-31T10:34:16Z

I think I defer to @douglascamata here. I'd want to make sure what we do is compatible with the websockets stuff which is probably coming in the next day or two. It is also possible he would want to merge something like that in the mean time and then he can go back and update it. Not sure, I'll wait for him.

Nihisil · 2016-07-31T11:07:31Z

I'm pretty sure we don't need to have user inputs in bot. It should be configured only from configs, because in that case we have ability to run it automatically by provision tools.

nikhil-pandey · 2016-07-31T11:16:22Z

@Nihisil Right. I think we should use a configuration file with a list of destinations to snipe. The destinations are removed once they are processed. I don't exactly know what the plan is with websockets. I assume it will be used to perform actions from the web later on through API calls? If so, same config file can be updated later during API calls.

Snipe Pokemons from List

nikhil-pandey · 2016-07-31T17:02:28Z

@douglascamata Could you please review this?

douglascamata · 2016-07-31T19:41:33Z

Merge conflicts again.

douglascamata · 2016-07-31T19:42:32Z

Please put the snipe coordinates inside the worker config parameter.

douglascamata · 2016-07-31T19:44:46Z

Also please consider adding the pokemon name along with each coordinate. This way snipping is more effective because it will search only for the pokemon you want to snipe and not for everything there..

ghost · 2016-07-31T21:46:16Z

@Nihisil @nikhil-pandey @douglascamata Are you guys suggesting we add the sniping coordinates to the already jam packed config file? If so I would have to disagree with you.

I believe the use case intended was to allow sniping of pokemon while the application was already running, allowing you to pass individual locations as you discover them without having to close the application then open, alter, and save the config.json and again relaunch the application each time.

I like the idea of adding the pokemon name along with the coordinate, but I would suggest this remain an optional feature.

./pokecli.py —snipe=True —location=1.232,1.232 —"Dragonite"

enjoy2000 · 2016-07-31T21:51:21Z

@Kassius509 Maybe an option for config file location is what u need. You can share it among your Docker instances.

On 1 Aug 2016, at 5:46 AM, Kassius509 notifications@github.com wrote:

with

Nihisil · 2016-08-01T00:27:10Z

@Kassius509 all flags in config.json can be overwrote by console arguments, it is a main approach (at least we try to do it).

BartKoppelmans · 2016-08-02T22:29:43Z

Just an idea, maybe we could work together with this site to use their database for sniping. That way we can just set sniping to true and automatically snipe the rare pokemon that get listed there.

Edit: Found more information on Rare Pokémon Spawns. If we could implement this in a way that it automatically passes the coordinates into the bot, it would be perfect! Perhaps we could try doing it with an event, that whenever a new pokémon is listed, it automatically triggers the snipe feature.

I am not too skilled with Python, but I could look at how the database could be made up and used with events. I would need someone else to help me with writing the code though.

nelsyeung · 2016-08-03T11:14:40Z

I've tried this and it doesn't seem to work at all.

[12:02:13]  Found location: 40.773115629, -73.980903625
[12:02:14]  Teleport to location..
[12:02:15]  No pokemon found!

I've basically tested this with common pokemon that are scanned from PokemonGo-Map, I used their provided coordinates with this and every one will return "No pokemon found!".

I've also tried the coordinates provided by Rare Pokemon Spawns, then confirm whether the Pokemon actually exists by putting the location into the PokemonGo-Map, finally input the location to snipe_list.json, but again, always, "No pokemon found!".

What am I missing with this? If my coordinates are not specific enough, is it not possible to have a configuration to expand the searching for the teleported part? That might cause softban but you can have a brute force way of teleporting to and back for the search.

enjoy2000 · 2016-08-03T12:55:32Z

@nelsyeung consider using this #1992 or checkout master branch on my fork

drees5 · 2016-08-03T14:15:36Z

i get this error
./pokecli.py --snipe=true
[15:11:45] PokemonGO Bot v1.0
[15:11:45] No config argument specified, checking for /configs/config.json
usage: pokecli.py [-h] [-cf CONFIG] [-a AUTH_SERVICE] [-u USERNAME]
[-ws WEBSOCKET.SERVER_URL]
[-wss WEBSOCKET.START_EMBEDDED_SERVER]
[-wsr WEBSOCKET.REMOTE_CONTROL] [-p PASSWORD] [-l LOCATION]
[-lc LOCATION_CACHE] [--forts.spin FORTS.SPIN] [-w WALK]
[-k GMAPKEY] [-d DEBUG] [-t TEST] [-du DISTANCE_UNIT]
[-ec EVOLVE_CAPTURED] [-rt RECONNECTING_TIMEOUT]
[-hr HEALTH_RECORD] [-ac FORTS.AVOID_CIRCLES]
[-mcs FORTS.MAX_CIRCLE_SIZE]
[--catch_randomize_reticle_factor CATCH_RANDOMIZE_RETICLE_FACTOR]
[--catch_randomize_spin_factor CATCH_RANDOMIZE_SPIN_FACTOR]
[--map_object_cache_time MAP_OBJECT_CACHE_TIME]
pokecli.py: error: unrecognized arguments: --snipe=true
(i have downloaded your fork)

JohnnyOmm · 2016-08-03T14:31:39Z

What do I type in to snipe a pokemon or add the location? theres no example besides this
{ "type": "SnipePokemon" },

nelsyeung · 2016-08-03T15:58:44Z

@JohnnyOmm If you use his master branch, you simply need to add that to the task and it will prompt you to enter a location. However, I myself can't really find pokemon that way reliably. I would also recommend #1992 if you want sniping.
@drees5 For his master branch, you don't need to specify a command line argument, you simply add "type": "SnipePokemon" to your tasks. If you are using his feature branch, you do the same but also you have to cp the snipe_list.example.json file to snipe_list.json then you run python pokecli.py -spl configs/snipe_list.json to make it work.

enjoy2000 · 2016-08-03T16:57:29Z

Remove argument —snipe=True pls, just need to add task SnipePokemon in config.json

On 3 Aug 2016, at 9:53 PM, drees5 notifications@github.com wrote:

i get this error
./pokecli.py --snipe=true
[15:11:45] PokemonGO Bot v1.0
[15:11:45] No config argument specified, checking for /configs/config.json
usage: pokecli.py [-h] [-cf CONFIG] [-a AUTH_SERVICE] [-u USERNAME]
[-ws WEBSOCKET.SERVER_URL]
[-wss WEBSOCKET.START_EMBEDDED_SERVER]
[-wsr WEBSOCKET.REMOTE_CONTROL] [-p PASSWORD] [-l LOCATION]
[-lc LOCATION_CACHE] [--forts.spin FORTS.SPIN] [-w WALK]
[-k GMAPKEY] [-d DEBUG] [-t TEST] [-du DISTANCE_UNIT]
[-ec EVOLVE_CAPTURED] [-rt RECONNECTING_TIMEOUT]
[-hr HEALTH_RECORD] [-ac FORTS.AVOID_CIRCLES]
[-mcs FORTS.MAX_CIRCLE_SIZE]
[--catch_randomize_reticle_factor CATCH_RANDOMIZE_RETICLE_FACTOR]
[--catch_randomize_spin_factor CATCH_RANDOMIZE_SPIN_FACTOR]
[--map_object_cache_time MAP_OBJECT_CACHE_TIME]
pokecli.py: error: unrecognized arguments: --snipe=true
(i have downloaded your fork)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1887 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADs-e0_dD2z_n8Jv_rjk9I9P7v0w4AsZks5qcKtmgaJpZM4JY2kH.

Kozeo · 2016-08-03T19:19:12Z

How do I test this?

JohnnyOmm · 2016-08-05T02:20:38Z

@nelsyeung I used the regular dev version and im getting this error when I add it to config
pokemongo_bot.tree_config_builder.ConfigException: No worker named SnipePokemon defined

tolinwei · 2016-08-13T00:31:13Z

Just found this PR, since PokemonGo-Map has been ceased, is this still working? If yes, what is the source of the teleport list – I read the previous comments and haven't found any here

nelsyeung · 2016-08-13T00:37:32Z

@tolinwei Check out this version of the PokemonGo-Map. If you want rare spawns try PokeSpawns. Also check out MoveToMapPokemon feature that's already out for the less specific sniping feature.

k4n30 · 2016-08-13T02:37:09Z

Should this be closed as the code it's based off is pretty old, and the movetomap task config option exists until #3672 is implemented?

elicwhite · 2016-08-13T02:59:46Z

Yeah, probably a good choice.

Thanks @enjoy2000, it will help provide us some base code to look at when building a new version.

sgitkene mentioned this pull request Jul 30, 2016

Suggestion: Synergy between PokemonGo-Map and this bot #1912

Closed

elicwhite reviewed Jul 31, 2016
View reviewed changes

[Feature] Snipe pokemon by tasks worker config

905b4f8

enjoy2000 force-pushed the feature/snipe-pokemon branch from 2ab669f to 905b4f8 Compare July 31, 2016 08:19

enjoy2000 added 2 commits July 31, 2016 16:24

Update run on first tick only

e9dfb5d

update

46f5c08

elicwhite reviewed Jul 31, 2016
View reviewed changes

Using BaseTask

9ac663d

elicwhite reviewed Jul 31, 2016
View reviewed changes

nikhil-pandey mentioned this pull request Jul 31, 2016

PokemonGo-Map Synergy #1992

Merged

update

71ec9d2

Nikhil Pandey and others added 3 commits July 31, 2016 19:35

Snipe Pokemons from List

760787e

Add example config

b36162a

Merge pull request #1 from nikhil-pandey/feature/snipe-pokemon

325b5b4

Snipe Pokemons from List

douglascamata added this to the 2.0 - stable release milestone Jul 31, 2016

douglascamata added New Functionality Waiting on Changes Help to Test labels Jul 31, 2016

julienlavergne mentioned this pull request Aug 1, 2016

pokemon catcher interface for https://github.com/AHAAAAAAA/PokemonGo-Map #2217

Closed

MFizz mentioned this pull request Aug 1, 2016

RemoveSoftBan before cating Pokémon in new Area #2234

Closed

licklake mentioned this pull request Aug 10, 2016

Rare Pokemon Idea!!!! #3402

Closed

umbreon222 mentioned this pull request Aug 12, 2016

sniping #3741

Closed

elicwhite closed this Aug 13, 2016

Draft feature to snipe pokemon #1887

Draft feature to snipe pokemon #1887

Conversation

enjoy2000 commented Jul 30, 2016

douglascamata commented Jul 30, 2016

enjoy2000 commented Jul 30, 2016

DayBr3ak commented Jul 30, 2016

wilsonyqm commented Jul 31, 2016

enjoy2000 commented Jul 31, 2016

elicwhite Jul 31, 2016

Choose a reason for hiding this comment

enjoy2000 commented Jul 31, 2016

nikhil-pandey commented Jul 31, 2016

nikhil-pandey commented Jul 31, 2016

elicwhite Jul 31, 2016

Choose a reason for hiding this comment

elicwhite commented Jul 31, 2016

elicwhite Jul 31, 2016

Choose a reason for hiding this comment

nikhil-pandey Jul 31, 2016 • edited Loading

Choose a reason for hiding this comment

enjoy2000 commented Jul 31, 2016 • edited Loading

elicwhite commented Jul 31, 2016

Nihisil commented Jul 31, 2016

nikhil-pandey commented Jul 31, 2016

nikhil-pandey commented Jul 31, 2016

douglascamata commented Jul 31, 2016

douglascamata commented Jul 31, 2016

douglascamata commented Jul 31, 2016

ghost commented Jul 31, 2016

enjoy2000 commented Jul 31, 2016

Nihisil commented Aug 1, 2016

BartKoppelmans commented Aug 2, 2016 • edited Loading

nelsyeung commented Aug 3, 2016

enjoy2000 commented Aug 3, 2016

drees5 commented Aug 3, 2016

JohnnyOmm commented Aug 3, 2016

nelsyeung commented Aug 3, 2016

enjoy2000 commented Aug 3, 2016

Kozeo commented Aug 3, 2016

JohnnyOmm commented Aug 5, 2016

tolinwei commented Aug 13, 2016

nelsyeung commented Aug 13, 2016

k4n30 commented Aug 13, 2016

elicwhite commented Aug 13, 2016

nikhil-pandey Jul 31, 2016 •

edited

Loading

enjoy2000 commented Jul 31, 2016 •

edited

Loading

BartKoppelmans commented Aug 2, 2016 •

edited

Loading