Honour logging settings from config to disable log level. #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for event_level in ['info', 'warning', 'error', 'critical', 'debug']: | ||
| if event_level == level and hasattr(self.bot.config, event_level) and not getattr(self.bot.config, event_level): | ||
| self._last_event = event | ||
| return |
There was a problem hiding this comment.
Yea ok, I see what you mean, let me fix that.
|
@douglascamata Please review |
|
@VeNoMouS this is a hack that won't stay here for very long time. Please, make this handler use the logging module just like the |
|
@douglascamata , sorry I don't understand what you mean in regards to Are you asking me to rewrite |
This was referenced Aug 11, 2016
Closed
|
@VeNoMouS if you can, yes, please. |
|
#3637 have a proper coloured logging handler rework to fix this. |
|
@douglascamata ah awesome, least a fix has been found :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
If 'debug' etc is set to False in config, then honour this setting by not logging it to CLI.