Spin Fort- Move to Fort : add timedout forts to recent_forts #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vosk, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @BriceSD and @TheSavior to be potential reviewers |
|
Could be solved with #3897 |
|
Closing this in favor of the approach that will be taken after #3897 |
|
Let me get this straight. I added a simple 3 line fix that uses ACTUAL server information, and you consider this an inferior approach compared to dumping to a json file after a hypothetical restart. So your argument is that "no, the server is wrong, that particular pokestop is not a recent fort, the cooldown is incorrect". Also, why do you think these changes are incompatible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restarting the bot, movetofort might pick a fort that spinfort will not spin due to cooldown.
When iterating cooldown forts in spinfort, add them to to recent_forts if not already contained, to guide
movetofort to other fort