Update the bot when starting the server

[bruvv]

Short Description:

I think it's a good idea that people will be forced to always update to the latest github version. Just to get them not banned for example and help the noobs out.

[mention-bot]

@nivong, thanks for your PR! By analyzing the annotation information on this pull request, we identified @simonsmh, @03t02 and @devn0ll to be potential reviewers

[devn0ll]

@nivong do you wan to put pip install -r requirements.txt in there too ? To make shure that if new requieremts come out that is save too ?

[bruvv]

ah yea forgot about that, will it also be usefull to put in
pip install -r requirements.txt --upgrade after?
ref: #3836

[BreezeRo]

That's never a good idea, if you want to update your project automatically you could use a cron job on your own set up

[simonsmh]

no it's not a good idea if dev is broken. close it and find a better way.

[danielsdian]

If the user installed the Master version, it will update it, right? even if dev is broken, the idea is for the users to run the Master version?

[thanhtran0302]

If I want to update, I prefer to do it myself, because sometime there is some modification that I don't want to update. And the role of run.sh is not to update the repo.

It's a bad idea to put theses lines in this script

[simonsmh]

Do you really want to notice the user that they have an update?
First git fetch
Then if git log = git log origin/dev(or master(how to check it automatically?))
Echo something like you have an update blablabla.
This is much better than force update.

In setup.sh I force all user to use dev branch which is a mistake. It should be fixed by creating another function to re sync to master.
@nivong

[MZorzy]

And what about config.json modifications ?

[danielsdian]

Why shouldnt the average user be automatically updated? Cant we make it so that if you are using the Master branch you get the update and if you are in the dev branch you dont and need to do it manually?

[devn0ll]

@danielsdian sounds good to me. I think on dev its alwyas better to update manualy

[BreezeRo]

+1 @danielsdian

[douglascamata]

Not a good idea, imho. What if I find a good commit and want to stick with it no matter what?

[bruvv]

Maybe change it that it only updates the master branche and that we add a configuration option to disable it.

[simonsmh]

We should make it automatically. Does anyone knows how to check branch is on master or dev?

root@simonsmh:~/PokemonGo-Bot# git branch -vv

• dev 9e65d3d [origin/dev] Improved documentation (Improved documentation #3921)

  master 63f777b [origin/master：落后 4] Dev merge to master
  , PR (Dev merge to master, PR #3334)
  root@simonsmh:~/PokemonGo-Bot#

Is it fit to use?

[acc3s]

git branch -m - would be better I think

[simonsmh]

Git branch -vv|grep "* master"
I am going to fix all things about it and open a new pr.

https://github.com/simonsmh/PokemonGo-Bot/blob/patch-9/run.sh
It's done.
#4003

[bruvv]

thanks closing this one. Thanks @simonsmh