Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configurable delay when spinning fort #4050

Closed
wants to merge 2 commits into from

Conversation

Quantra
Copy link
Contributor

@Quantra Quantra commented Aug 16, 2016

Short Description:

_Needs example configs updating & docs_

This PR allows the user to set min and max time spent spinning a pokestop and replaces the previous 2 second pause.

      {
        "type": "SpinFort"
        "config": {
          "spin_wait_min": 2,
          "spin_wait_max": 3
        }
      }

With #3872 and #4048 everything should have a user configurable delay in it's own task config.

@mention-bot
Copy link

@Quantra, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @sinap and @TheSavior to be potential reviewers

@Quantra Quantra changed the title Spin delay min max User configurable delay when spinning fort Aug 16, 2016
@MZorzy
Copy link

MZorzy commented Aug 16, 2016

Why not have a special humanpauseconfig.json with all pause and let config.json small ?

@Quantra
Copy link
Contributor Author

Quantra commented Aug 16, 2016

@MZorzy I think all task related config should be set in the task's config. I don't want to look somewhere else in the config or another file.

@BriceSD
Copy link
Member

BriceSD commented Aug 16, 2016

@Quantra You made a PR in master, open an other one in dev please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants