Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .get_alt() method to Polyline class #4470

Merged
merged 4 commits into from
Aug 21, 2016
Merged

Add .get_alt() method to Polyline class #4470

merged 4 commits into from
Aug 21, 2016

Conversation

th3w4y
Copy link
Contributor

@th3w4y th3w4y commented Aug 21, 2016

Short Description:

Use Google Maps Elevation api to get the elevations along the path of the polyline

Fixes

  • Implements .get_alt() method

@mention-bot
Copy link

@th3w4y, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kanemasa1987, @sinap and @asnelzin to be potential reviewers

@MZorzy
Copy link

MZorzy commented Aug 21, 2016

i think is better pick altitude at start.
then use some "noise" when walk, and upgrade altitude after x time, so low use google API (will not work after 2500 query?)

@th3w4y
Copy link
Contributor Author

th3w4y commented Aug 21, 2016

@MZorzy this uses only one API request per Polyline object created
With one request you get max 512 altitudes values along the polyline path (generated by one Directions API request)

Plus to mention we have 2500 Direction requests and 2500 Elevations requests, thus they consume a different quota since is a different API.

Thus this will not add any pressure on the quota of the already usage of the google API

@mjmadsen mjmadsen merged commit c061fc2 into PokemonGoF:dev Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants