Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use berry again only if capture failed #4501

Merged
merged 2 commits into from
Aug 21, 2016
Merged

Conversation

congito
Copy link
Contributor

@congito congito commented Aug 21, 2016

Short Description:

I'm seeing the bot was throwing berry again after the ball had completely missed the pokemon:

[pokemon_appeared] A wild Aerodactyl appeared! [CP 793] [NCP 0.37] [Potential 0.49] [A/D/S 6/1/15]
[threw_berry] Threw a Razz Berry! Catch rate with Pokeball is now: 24.01
[threw_pokeball] Nice Curveball throw! Used Greatball, with chance 34.53 (40 left)
[pokemon_capture_failed] Pokeball thrown to Aerodactyl missed.. trying again!
[threw_berry] Threw a Razz Berry! Catch rate with Pokeball is now: 36.01

However, that is not allowed in the game. One can only use berries again after capture had failed.

@mention-bot
Copy link

@oopdas, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pokepal, @BreezeRo and @Likael to be potential reviewers

@solderzzc
Copy link
Contributor

oh, big catch!

@solderzzc solderzzc merged commit abed749 into PokemonGoF:dev Aug 21, 2016
@alexyaoyang
Copy link
Contributor

Great catch, I was about to work on this! This fixed #4290. 👍

@solderzzc
Copy link
Contributor

@alexyaoyang Thanks all the same 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants