Add to ignore if scanning too often #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjmadsen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @BriceSD and @TheSavior to be potential reviewers |
| c.execute("SELECT COUNT(name) FROM sqlite_master WHERE type='table' AND name='softban_log'") | ||
| result = c.fetchone() | ||
|
|
||
| while True: |
There was a problem hiding this comment.
Why there was a while True: ? It seems just one time run, why placed the while here
There was a problem hiding this comment.
I'm not terribly sure about this DB code.
|
Yes, your fix will improve the real soft ban log. |
|
@solderzzc That look better. Yeah, the original source had a break after each if and appeared to not need looping. Removed. |
|
@mjmadsen thanks a lot, got merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #4497 and reoccurring similar problems