Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize docker image (continuation of #4730) #4783

Merged
merged 3 commits into from
Aug 26, 2016
Merged

Minimize docker image (continuation of #4730) #4783

merged 3 commits into from
Aug 26, 2016

Conversation

th3w4y
Copy link
Contributor

@th3w4y th3w4y commented Aug 26, 2016

Short Description:

Fixes some issues from PR #4730

Fixes

  • busybox tar does not support --strip-components argument - added and removed regular tar in same RUN step
  • rectify cache invalidation issue in Dockerfile after merge of Minimize docker image #4730 (because the download of the $BUILD_BRANCH.tar.gz was in a an RUN step and cache was not invalidated - no new image would have been built)
  • split pgoencrypt part into a different layer (this is in order to check if there is a new pgoencrypt version ) - executed in an different step after requirements to not cause the invalidation of the requirements build step (which is the most expensive)

@mention-bot
Copy link

@th3w4y, thanks for your PR! By analyzing the annotation information on this pull request, we identified @walkerlee, @nivong and @lawliet89 to be potential reviewers

@th3w4y th3w4y changed the title Minimize docker image continuation of #4730 Minimize docker image (continuation of #4730) Aug 26, 2016
@th3w4y th3w4y mentioned this pull request Aug 26, 2016
@solderzzc solderzzc merged commit fa2025f into PokemonGoF:dev Aug 26, 2016
@th3w4y th3w4y deleted the docker branch August 26, 2016 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants