Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added separate config #4793

Merged
merged 2 commits into from
Aug 27, 2016
Merged

added separate config #4793

merged 2 commits into from
Aug 27, 2016

Conversation

rawgni
Copy link
Contributor

@rawgni rawgni commented Aug 27, 2016

Short Description:

Fixes/Resolves/Closes (please use correct syntax):

- #4781

@mention-bot
Copy link

@rawgni, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bruno-kenji, @anakin5 and @mhdasding to be potential reviewers

@solderzzc
Copy link
Contributor

You sure you want to change as this way? Many support ticket will be opened.
How about add a auth in current main config file to point to the auth.conf? This will keep current config file working without changes.

@rawgni
Copy link
Contributor Author

rawgni commented Aug 27, 2016

@solderzzc i believe the current config will still work without a problem, ie. only using config.json instead of having auth.json and config.json.

It basically loads auth.json and then update it with whatever is in config.json. If there is nothing in auth.json then you get whatever is in config.json

@solderzzc
Copy link
Contributor

@rawgni Yes, I just understood your code. Thanks a lot.

@solderzzc solderzzc merged commit b2da6d0 into PokemonGoF:dev Aug 27, 2016
@MZorzy
Copy link

MZorzy commented Aug 27, 2016

Why not move *example to an subdir like ./configs/example
And let user have only real configs files under ./configs ?

Auth.json with fixed data
Some config.json
Location.json with preferred cities (need to add altitude)

@rawgni rawgni deleted the separate_config branch August 27, 2016 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants