Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign to Team #5067

Merged
merged 7 commits into from
Sep 2, 2016
Merged

Assign to Team #5067

merged 7 commits into from
Sep 2, 2016

Conversation

DeXtroTip
Copy link
Contributor

Short Description:

It makes it able to choose a team when reaching level 5.
Not sure if it is still wanted since some may think it is better done manually.
As someone said before, if it doesn't feel right having this inside CompleteTutorial task, I can create a new task for this.

Haven't updated docs file since there were nothing about this task there, will do it later on in another PR.

Fixes/Resolves/Closes (please use correct syntax):

def should_run(self):
return self.may_run
self.tutorial_run = True
self.team_run == True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.team_run = True?

@@ -26,7 +26,9 @@
"config": {
"enabled": false,
"// set a name": "",
"nickname": ""
"nickname": "",
"// 0 = No Team, 1 = Blue, 2 = Red, 3 = Yellow": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red is 2 ... I thought Red is 3...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax = "proto3";
package POGOProtos.Enums;

enum TeamColor {
    NEUTRAL = 0;
    BLUE = 1;
    RED = 2;
    YELLOW = 3;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's wired, the red always jumped as the 3rd one.

@solderzzc
Copy link
Contributor

solderzzc commented Sep 1, 2016

👍

Approved with PullApprove

@k4n30
Copy link
Contributor

k4n30 commented Sep 1, 2016

Uhhh ..... did the automerge not work?

@solderzzc
Copy link
Contributor

solderzzc commented Sep 1, 2016

👍

Approved with PullApprove

@k4n30 k4n30 closed this Sep 1, 2016
@k4n30 k4n30 reopened this Sep 1, 2016
@k4n30
Copy link
Contributor

k4n30 commented Sep 1, 2016

@solderzzc think it's broken :(

@DeXtroTip DeXtroTip closed this Sep 2, 2016
@DeXtroTip DeXtroTip reopened this Sep 2, 2016
@solderzzc
Copy link
Contributor

solderzzc commented Sep 2, 2016

👍

Approved with PullApprove

@solderzzc
Copy link
Contributor

@k4n30 let me try it..

@solderzzc
Copy link
Contributor

Oh, @DeXtroTip already fixed it.

@solderzzc solderzzc merged commit b3ffdf9 into PokemonGoF:dev Sep 2, 2016
@DeXtroTip DeXtroTip deleted the set_team branch September 2, 2016 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants