Experimental #5002

[sohje]

Short Description:

Experimental wait at fort with lure module plugged

Fixes/Resolves/Closes (please use correct syntax):

• [Feature Request] Wait at fort if lure is on #5002
• Bot will stay near fort till lure module expired
• Disabled by default

To enable:

      {
        "type": "MoveToFort",
        "config": {
            "enabled": true,
            "lure_attraction": true,
            "lure_max_distance": 1000,
            "wait_on_lure": true,
            "log_interval": 5
        }
      }

TODO:

• Need some tests (already spent 15 lure modules)
• Implement wait at fort for specified amount of time config option (like: wait_on_lure_max: "20", etc)
• Documentation update

[mention-bot]

@sohje, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @z4ppy to be potential reviewers

[MZorzy]

question (can't undertand code ) when it stop near fort, gps noise is active or is extremely fixed?

[th3w4y]

@sohje I cannot see how you are waiting...

[sohje]

@th3w4y We filter forts by 'active_fort_modifier' if self.wait_at_fort enabled.
Always receiving fort with Lure module on get_nearest_fort() untill it expired.

[th3w4y]

is this still removing the forts on timeout?

In [31]: wait_at_fort = True

In [32]: forts
Out[32]: 
[{'active': True, 'id': 10},
 {'active': True, 'id': 20},
 {'active': True, 'id': 40}]

In [33]: timeouts_ids
Out[33]: [10, 20, 30]

In [34]: filter(lambda q: q["id"] not in timeouts_ids or (q.get("active", False) and wait_at_fort), forts)
Out[34]: 
[{'active': True, 'id': 10},
 {'active': True, 'id': 20},
 {'active': True, 'id': 40}]

In [35]: 

[sohje]

Nope, cause we dont need to care about forts_on timeout here. We standing and waiting for lures and spin fort with lure module on timeout(check spin_fort.py update L186)

[z4ppy]

Nice PR ! thanks you :)

[solderzzc]

@sohje Will it spin forts when wait on fort? is the timeout checking already in code?

[sohje]

@solderzzc Yeap, bot will spin forts.

    def get_forts_in_range(self):
        forts = self.bot.get_forts(order_by_distance=True)
        now = time.time() * 1000
        forts = filter(lambda x: x.get('cooldown_complete_timestamp_ms', 0) < now, forts)
        # forts = filter(lambda fort: fort["id"] not in self.bot.fort_timeouts, forts)

[solderzzc]

👍

[sohje]

@solderzzc re-approve and merge?

[solderzzc]

👍