Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive Vanish Limit & Rest #5115

Merged
merged 2 commits into from
Sep 2, 2016
Merged

Conversation

alexyaoyang
Copy link
Contributor

@alexyaoyang alexyaoyang commented Sep 2, 2016

Allow user to set consecutive vanish limit and also rest duration if limit reached

Fixes/Resolves/Closes (please use correct syntax):

screenshot 2016-09-02 at 12 52 29 pm

Note: If there is a sqlite3.OperationalError: no such table: vanish_log error, delete DB file to fix ( data/yourusername.db). This resets your daily catch limit tho. Maybe @BreezeRo has an better fix?

@alexyaoyang alexyaoyang changed the title Consecutive Vanish Limit Consecutive Vanish Limit & Rest Sep 2, 2016
@solderzzc
Copy link
Contributor

@alexyaoyang How do you think to have this feature?
And I feel the way to structure code in the capture worker is turning this file bigger. Is that better to have separated process logic ? We already have a alive/random/deep sleep workers, how should those tasks be structured ?

@alexyaoyang
Copy link
Contributor Author

alexyaoyang commented Sep 2, 2016

@solderzzc The idea is actually from FR #4510. Yes I totally agree, I was thinking of moving all the anti-ban measurements into another worker, but don't want to make this PR too huge to approve. I will submit another separate PR next week (weekend roadtrip!) for code decoupling or separation of concern 👍

@solderzzc
Copy link
Contributor

@alexyaoyang If so, it's up to you to merge this PR in to keep it up to date.

@solderzzc
Copy link
Contributor

solderzzc commented Sep 2, 2016

👍

Approved with PullApprove

@alexyaoyang
Copy link
Contributor Author

alexyaoyang commented Sep 2, 2016

👍

@solderzzc
Copy link
Contributor

solderzzc commented Sep 2, 2016

👍

Approved with PullApprove

@alexyaoyang alexyaoyang merged commit ebfead0 into PokemonGoF:dev Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants