Fix bot never try to walk to not snipable pokemons #5207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When both `snipe` and `snipe_high_prio_only` are on, the bot now will try to walk to unqualified pokemons (for sniping). * Remove unnecessary sleep in snipe chain
|
@martixingwei, thanks for your PR! By analyzing the annotation information on this pull request, we identified @solderzzc, @DBa2016 and @chrisle to be potential reviewers |
| @@ -341,16 +341,12 @@ def work(self): | |||
| self.snipe(pokemon) | |||
| count = count +1 | |||
| if count >= self.config.get('snipe_max_in_chain', 2): | |||
| return WorkerResult.SUCCESS | |||
| if count is not 1: | |||
| time.sleep(self.config.get('snipe_sleep_sec', 2)*5) | |||
There was a problem hiding this comment.
Why? I think the bot should continue to move to next pokemon after sniping the high priority pokemons.
There was a problem hiding this comment.
Do you mean the sleep is a must? There already sleeps in snipe function. What does this sleep for?
|
This PR is not good. Will break the balance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
snipeandsnipe_high_prio_onlyare on, the bot now will try to walk to next pokemon after sniping.Fixes/Resolves/Closes (please use correct syntax):