Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bot crash on telegram egghatch #5270

Merged
merged 5 commits into from
Sep 8, 2016
Merged

Fix bot crash on telegram egghatch #5270

merged 5 commits into from
Sep 8, 2016

Conversation

Gobberwart
Copy link
Contributor

@Gobberwart Gobberwart commented Sep 7, 2016

Fixes a crash when telegram_handler tries to send an egg hatched notification.

@mention-bot
Copy link

@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @solderzzc, @DBa2016 and @askovpen to be potential reviewers

@Gobberwart Gobberwart changed the title Dev egghatch Fix bot crash on telegram egghatch Sep 7, 2016
@Gobberwart
Copy link
Contributor Author

Don't merge this yet. There's still a problem with egg_hatch events. Working on it.

@solderzzc
Copy link
Contributor

Sure...

Data["iv"] not valid, replaced with "ivcp" and "iv_ads" as per log
message
@Gobberwart
Copy link
Contributor Author

Should be ok to merge now @solderzzc

@solderzzc
Copy link
Contributor

solderzzc commented Sep 8, 2016

👍

Approved with PullApprove

@solderzzc solderzzc merged commit 3e33e6d into PokemonGoF:dev Sep 8, 2016
@Gobberwart Gobberwart deleted the dev_egghatch branch September 8, 2016 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants