Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored, improved and fixed SleepSchedule #5278

Merged
merged 18 commits into from
Sep 8, 2016
Merged

Refactored, improved and fixed SleepSchedule #5278

merged 18 commits into from
Sep 8, 2016

Conversation

cmezh
Copy link
Contributor

@cmezh cmezh commented Sep 8, 2016

Short Description:

  • Refactored code
  • Fixed edge case if sleep time has started previous day
  • Brought back SCHEDULING_MARGIN
  • Removed unused LOG_INTERVAL_SECONDS
  • Unified time output format
  • Added option to enable/disable whole SleepSchedule
  • Added option to enable/disable every single schedule entry
  • Added sleep reminder feature
  • Improved behaviour in cases if config is empty of all entries are disabled
  • Improved behaviour on config parsing/missing config keys errors (ValueError for time and duration, warning for time_random_offset and duration_random_offset)
  • Updated existing tests and added some more
  • Updated configuration_files.md

Fixes:

Config format has been changed. If no entries key is present in config, SleepSchedule will throw warning with link to configuration_files.md

@mention-bot
Copy link

@cmezh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rawgni, @buluba89 and @supercourgette to be potential reviewers

@solderzzc
Copy link
Contributor

solderzzc commented Sep 8, 2016

👍

Approved with PullApprove

@solderzzc solderzzc merged commit 3c4e92d into PokemonGoF:dev Sep 8, 2016
@ghost
Copy link

ghost commented Sep 8, 2016

Are favorite locations now supported by SleepSchedule?

@cmezh
Copy link
Contributor Author

cmezh commented Sep 8, 2016

@acurioustale No, not yet. Maybe in next PR.

@cmezh cmezh deleted the sleepsched3 branch September 8, 2016 11:15
This was referenced Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants