-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple hb from step walker #5292
Conversation
@sohje, thanks for your PR! By analyzing the annotation information on this pull request, we identified @anakin5, @mjmadsen and @alexyaoyang to be potential reviewers |
@sohje what is calling heartbeat now? |
@th3w4y Heartbeat works in separate thread now, with timer and another checks, like block hb from sniping. |
@sohje That part i noticed, what is did not noticed yet is when is this called except .login()
|
threading.Timer(self.heartbeat_threshold, self.heartbeat).start() |
@th3w4y |
@sohje Looks perfect to me like I was saying previous comments this actually fixes a real bug |
Short Description:
Decouple hb from step walker due to #5243
Fixes/Resolves/Closes (please use correct syntax):