Improvements Pokemon Optimizer #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -342,11 +342,12 @@ Every Pokemon not selected is candidate for transfer. | |||
| | `mode` | `"by_pokemon"`, `"by_family"`, `"overall"` | `"by_family"` | | |||
|
|
|||
| The `mode` define how the Pokemon Optimizer is going to apply the rule. | |||
| - `"by_pokemon"` will apply the rule for each Pokemon. | |||
| <br>In that mode, each Pokemon will be compared to other Pokemon of the same name. | |||
| - `"by_pokemon"` will apply the rule for each Pokemon. That is for every types of Pokemon individually. | |||
There was a problem hiding this comment.
Not sure this is clear.
Could just be "will apply the rule for each individual pokemon type (eg. "Rattata", "Pidgey", "Clefairy" etc.)"
There was a problem hiding this comment.
ok, but the example would be misleading since it does not contains 2 pokemon of the same family.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update doc for #5275
Reduce log when nothing to do for #5235