-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py3convert #5442
Py3convert #5442
Conversation
I tested on 2.7 for 2 hours with no issues. |
from pokemongo_bot.inventory import Pokemons, Pokemon, Attack | ||
from pokemongo_bot.inventory import Attack | ||
from pokemongo_bot.inventory import Pokemon | ||
from pokemongo_bot.inventory import Pokemons | ||
from operator import attrgetter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious over here, is there a reason for separating the multiple module import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pep-8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I ran flake8
over the codebase during the conversion in e31c2a7~ -- figured it was a good time to make those changes, while I was mass-changing imports anyway. :)
GitHub refuses to update with the proper commits, fixing that merge conflict. Closing and submitting a new PR. |
Short Description:
Update bot to be cross compatible with Python 3.5+ and Python 2.7+.
Was already being tested at
PokemonGoF/PokemonGo-Bot-Backup#26
Fixes/Resolves/Closes (please use correct syntax):
N/A