Py3convert #5442
Closed
Py3convert #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on 2.7 for 2 hours with no issues. |
alexyaoyang
reviewed
Sep 16, 2016
| from pokemongo_bot.inventory import Pokemons, Pokemon, Attack | ||
| from pokemongo_bot.inventory import Attack | ||
| from pokemongo_bot.inventory import Pokemon | ||
| from pokemongo_bot.inventory import Pokemons | ||
| from operator import attrgetter |
There was a problem hiding this comment.
Just curious over here, is there a reason for separating the multiple module import?
There was a problem hiding this comment.
Yeah, I ran flake8 over the codebase during the conversion in e31c2a7~ -- figured it was a good time to make those changes, while I was mass-changing imports anyway. :)
|
GitHub refuses to update with the proper commits, fixing that merge conflict. Closing and submitting a new PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Update bot to be cross compatible with Python 3.5+ and Python 2.7+.
Was already being tested at
PokemonGoF/PokemonGo-Bot-Backup#26
Fixes/Resolves/Closes (please use correct syntax):
N/A