use strip instead of replace for names with spaces

[ChaosMarc]

once again because my pull request is now at PokemonGo-Bot-Backup.

The configuration of evolve_list and donot_evolve_list doesn't work for "Nidoran F" and "Nidoran M" because when splitting the commaseparated string to an array their names are completely stripped of whitespaces with .replace(" ", "") leading to "NidoranF" and "NidoranM". To prevent this .strip() should be used to trim only leading and trailing whitespaces.

see DeXtroTip's comment:

Before, it was using strip() and then someone said it didn't work because "Nidoran F" and "Nidoran M" names in bot are stored as "NidoranF" and "NidoranM", that's why it was change to replace().
EDIT - I've checked and the bot actually stores the names as "Nidoran F" and "Nidoran M" so it should simply use strip() and not replace()

[mention-bot]

@ChaosMarc, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Gobberwart, @achretien and @alexyaoyang to be potential reviewers

[solderzzc]

Why all checks have passed, but the status is still yellow(Required statuses must pass before merging)

[Gobberwart]

No. Replace was used specifically for Nidoran M/F which was being represented as NidoranM NidoranF (no spaces). If you change this, something will break. Give me a minute to get the specifics. Please do not merge!

[Gobberwart]

Here is the PR where strip was changed to replace #5256
And here's the issue it addressed: #5239

The bot was unable to match Nidoran M/Nidoran F. Changing to replace allowed it to match NidoranM/NidoranF. Changing back to strip may reintroduce this issue (although it may have been fixed elsewhere since PR #5256)

[Gobberwart]

OK, checked and someone has corrected the way pokemon names are stored in inventory, so this can now be reverted to strip.

[alexyaoyang]

👍