Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release_below_ivcp and keep_best_ivcp #5465

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Added release_below_ivcp and keep_best_ivcp #5465

merged 1 commit into from
Sep 16, 2016

Conversation

Gobberwart
Copy link
Contributor

Short Description:

Added release_below_ivcp and keep_best_ivcp to TransferPokemon

Reviewers please check this very carefully as I may have missed something important

Fixes/Resolves/Closes (please use correct syntax):

@Gobberwart Gobberwart mentioned this pull request Sep 16, 2016
Copy link
Contributor

@javajohnHub javajohnHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell it looks good. But I requested the feature so I might be bias.

@Gobberwart
Copy link
Contributor Author

Heh, I might wait for another review... @solderzzc @DBa2016 @alexyaoyang @mjmadsen ?

@solderzzc
Copy link
Contributor

solderzzc commented Sep 16, 2016

👍 seems good. I haven't found issues with this PR.

Approved with PullApprove

@Gobberwart
Copy link
Contributor Author

Alright. Merging. Hope it's right :)

@Gobberwart Gobberwart merged commit 17dac41 into PokemonGoF:dev Sep 16, 2016
@Gobberwart
Copy link
Contributor Author

Dammit, I knew there'd be an error somewhere. Looking at it.

@Gobberwart
Copy link
Contributor Author

Hmmm line 59 isn't even a line..

@Gobberwart
Copy link
Contributor Author

I can't see the issue... Not even sure it's got anything to do with this PR.

    def _release_pokemon_worst_in_group(self, group, pokemon_name):
        keep_best, keep_best_cp, keep_best_iv, keep_best_ivcp = self._validate_keep_best_config(pokemon_name)

@alexyaoyang
Copy link
Contributor

Found it, opening PR. 👍

alexyaoyang pushed a commit to alexyaoyang/PokemonGo-Bot that referenced this pull request Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants