Improve telegram startup, fix master/sub issues #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved startup for me by several seconds.
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DBa2016, @askovpen and @javajohnHub to be potential reviewers |
|
Work in progress. @javajohnHub your thoughts? |
javajohnHub
approved these changes
Sep 18, 2016
No point calling the telegram handler at all if no msg to send (should be faster!)
|
Still work in progress due to issues with master. Working on it. |
Events return sorted alphabetically. Just makes things easier to read/find and tends to group like events together.
|
OK, this should be right for final testing/approval. I found a bug in the "master" identification logic, so have done some refactoring and logic fixing. Now works correctly with master in config or not (numeric or username), password authentication, multiple masters again. |
This has been moved to chathandler, so not needed in telegramhandler. All other imports required/in use.
|
Sorry, wasn't QUITE ready. Now it is and I'm not touching it again unless someone finds a bug. |
Gobberwart
changed the title
|
Approval from @YvesHenri, merging. |
This was referenced Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
At startup, telegram handler follows this pattern... Create bot instance -> Connect to Telegram API -> Split to new thread.
Connect might take several seconds, slowing bot startup while running in main thread.
Changed to Create bot instance -> Split to new thread -> Connect to Telegram API
For me, startup time reduced from 9 seconds to <3 consistently. YMMV.
In addition, there were some issues with bot correctly identifying and sending info to master unless explicitly set in config. Some refactoring and logic fixes made to correct this.
Fixes/Resolves/Closes (please use correct syntax):