Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex pattern for gps coordinates #5578

Merged
merged 1 commit into from
Sep 21, 2016
Merged

fix regex pattern for gps coordinates #5578

merged 1 commit into from
Sep 21, 2016

Conversation

ukos-git
Copy link
Contributor

@ukos-git ukos-git commented Sep 20, 2016

Short Description:

fixes limited input for gps-coordinates in json files in FollowPath worker.
Too short Numbers like 1.23 were not recognised by the old logic.
Instead you would have to write 1.230.
The new pattern now also supports natural numbers like 1 and 2 as well as 1.1 and 2.2

Fixes/Closes

#5413

Too short Numbers like 1.23 were not recognised by the old logic.
Instead you would have to write 1.230.
The new pattern now also supports natural numbers like 1 and 2 as well as 1.1 and 2.2
@cowst
Copy link

cowst commented Sep 21, 2016

did it result on crashes?
if yes, i experienced this issue as well but thought was specific for sniping.

@alexyaoyang
Copy link
Contributor

alexyaoyang commented Sep 21, 2016

👍

Approved with PullApprove

@alexyaoyang alexyaoyang merged commit 62d674a into PokemonGoF:dev Sep 21, 2016
@ukos-git ukos-git deleted the regex_fix_for_gps_coordinates branch September 24, 2016 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants