-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging release_config.json with config.json #568
Conversation
Should perhaps consider adding in the catch-ignore.yml file as well to the config merge, keeping all the config files in one place. Especially since this might be considered a sort of "release configuration". |
"release_under_iv": 0.8, | ||
"cp_iv_logic": "or" | ||
}, | ||
"My Pokemon": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not clear enough. Always put the default values in. Adding all the pokemon names would be more clear
We should write the config file just like sublime text config files. Lots of comments with default value initially set. In my opinion having all the settings in a single config file would be to complex. A good structure could be /PokemonGo/AdvanceSettings/catch-ignore.json
In the future AdvanceSettings can be renamed as /PokemonGo/Packages and people can write custom packages with custom package settings as |
@thellimist We need to have some approach that supports the direction of #142 |
#766 wants to allow multiple config files. It would be simpler to have everything in one file for that PR. |
Please do not! Keep release_config, but add additional parameter in config.json which indicate release_config should use! |
function may already be coming by @SteffanLong. if not, you can collaborate |
If we're going to move config files, and merge them, we may as well merge three different ways of catching/releasing as well. I have a draft we're working on. Join the Slack so we can perfect it. :) |
This is fully implemented in the dev branch now. |
Short Description: Instead of having two required configuration files, we are merging them together.