Wander

[janpascal]

Short Description:

Restores the behaviour of the loiter field in the path.json for FollowPath.
Renames loiter to wander to avoid future misunderstandings.

Fixes/Resolves/Closes (please use correct syntax):

Fixes #5416
Fixes #5488

[mention-bot]

@janpascal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @javajohnHub, @YvesHenri and @DBa2016 to be potential reviewers

[alexyaoyang]

@janpascal Thanks for fixing the wander function! I believe the MoveToFort task was also changed similarly previously. Do you think we should change it back too?

[mudmud2k]

I think it's better to let loitering be like it is and just add a wandering/wander/wanderlust/stroll option...

It's just one config element more,... further we could add it also in the track.json file, when it should just wander or loiter (stroll/dawdle)

[alexyaoyang]

@mudmud2k After this PR is merged, you can still do a stand-still loiter with the wander feature, just don't have any move task below FollowPath 👍

[janpascal]

@alexyaoyang: Probably, but I'm not familiar with the MoveToFort task. I can imagine that the changes you refer to may cause the bot to get blocked, if the following FollowSpiral task (in the default config) doesn't get a chance to take the bot away in case it gets stuck just following pokestops.

@mudmud2k, @alexyaoyang: If enough people are interested, I can add a loiter option (in the new sense of the option). But let's get this PR merged first.

[alexyaoyang]

👍 Ah I see, so wander now applies only for FollowPath. I think that is a good idea.

Agree, let's get this merged first.