Evolving based on IV and CP #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, but I know we're trying to refactor the code into an event-driven worker-plugin system. Evolution will eventually be migrated into a worker, perhaps this PR should do that? |
|
Evolution is already its separate worker, so not sure how this applies? There is definitely refactoring to do to have the workers share some utility functionalities - but this is beyond just this worker. I'll do it myself if I get around to it soon, but that might not be the case. Also, this change is fairly small but very useful. I've been using it for the past two days and it does a much better job compared to just CP. |
|
Please help to check the README, if feature list updated. |
MFizz
pushed a commit
to MFizz/PokemonGo-Bot
that referenced
this pull request
Jul 29, 2016
* fixed a bug with zero values in release_config causing bot to crash * added evolve all option * added evolve all option * added evolve all option * added to contrib. list * sorting pokemons by cp * stepper update from upstream * much improved evolve all * Update README.md * updated config example * longer sleeps - to avoid flooding the servers * mixed IV and CP evolving * Update README.md * modified config example * shorter sleep duration after failed evolve. Should make things faster * shorter sleep duration after success evolve. Should make things faster * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Instead of evolving pokemons by their CP, evolving is now done by IV first. To prevent situations where ridiculously low CP pokemons with high IVs are evolved, there is a new optional config value cp_min (default: 300). This is used as a threshold - first, all larger (than the threshold) CP pokemons are evolved based on their IV. Then, if possible, lower CP pokemons are evolved based on their CP alone, since presumably IV doesn't matter that much then.